Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
LiliDeng committed Nov 15, 2024
1 parent fe23388 commit 4bd444c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion lisa/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -361,10 +361,11 @@ def get_information(self, force_run: bool = True) -> Dict[str, str]:
informations.reverse()
for current_information in informations:
for key, value in current_information.items():
if value or key not in temp_information:
if value is not None or key not in temp_information:
temp_information[key] = value

self._information_cache = temp_information
self.log.debug(f"Updated _information_cache: {self._information_cache}")
return self._information_cache

def mark_dirty(self) -> None:
Expand Down
6 changes: 3 additions & 3 deletions lisa/tools/fio.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ class FIOResult:
"FIOMODES",
[
"randread",
"randwrite",
"read",
"write",
# "randwrite",
# "read",
# "write",
],
)

Expand Down
1 change: 1 addition & 0 deletions microsoft/testsuites/performance/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def perf_disk(
# This limitation is only needed for 'libaio' ioengine but not for 'io_uring'.
if ioengine == IoEngine.LIBAIO:
numjob = min(numjob, 256)
max_iodepth = 2
for mode in FIOMODES:
iodepth = start_iodepth
numjobindex = 0
Expand Down

0 comments on commit 4bd444c

Please sign in to comment.