Skip to content

Commit 977cba1

Browse files
Merge branch 'microsoft:main' into msri_enhanced_planning
2 parents 3d94ed7 + 8124415 commit 977cba1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+559
-301
lines changed

.github/workflows/checks.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
3737
3838
lint:
39+
needs: format
3940
runs-on: ubuntu-latest
4041
steps:
4142
- uses: actions/checkout@v4
@@ -55,6 +56,7 @@ jobs:
5556
poe lint samples
5657
poe lint tests
5758
pyright:
59+
needs: lint
5860
runs-on: ubuntu-latest
5961
steps:
6062
- uses: actions/checkout@v4
@@ -73,6 +75,7 @@ jobs:
7375
poe pyright src
7476
7577
test:
78+
needs: pyright
7679
runs-on: ubuntu-latest
7780
steps:
7881
- uses: actions/checkout@v4

.github/workflows/docker-build-push.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ jobs:
2323
matrix:
2424
image:
2525
- name: magentic-ui-browser
26-
context: src/magentic_ui/docker/magentic-ui-browser-docker
26+
context: docker/magentic-ui-browser-docker
2727
registry_name: microsoft/magentic-ui-browser
2828
- name: magentic-ui-python-env
29-
context: src/magentic_ui/docker/magentic-ui-python-env
29+
context: docker/magentic-ui-python-env
3030
registry_name: microsoft/magentic-ui-python-env
3131

3232
steps:

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -357,11 +357,10 @@ yarn build
357357
magentic-ui --port 8081
358358
```
359359

360-
>**Note**: Running this command for the first time will build two docker containers required for the Magentic-UI agents. If you encounter problems, you can build them directly with the following commands from inside the repository:
360+
>**Note**: Running this command for the first time will pull two docker images required for the Magentic-UI agents. If you encounter problems, you can build them directly with the following command:
361361
```bash
362-
docker build -t magentic-ui-vnc-browser:latest ./src/magentic_ui/docker/magentic-ui-browser-docker
363-
364-
docker build -t magentic-ui-python-env:latest ./src/magentic_ui/docker/magentic-ui-python-env
362+
cd docker
363+
sh build-all.sh
365364
```
366365

367366
#### Running the UI from source

TROUBLESHOOTING.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,26 +35,21 @@ Please read [Linux post-installation steps for Docker Engine
3535
- Make sure port 8081 is not being used by another application.
3636
- You can change the port with `magentic ui --port <another_port>`.
3737

38-
## 3. 🏗️ Docker Image Build Fails
38+
## 3. 🏗️ Docker Image Pull Fails
3939

4040
**Error:**
41-
`build docker image Failed` or similar
41+
`Pulling docker image...Failed` or similar
4242

4343
**Solution:**
44-
- First try to rebuild the docker with the command:
45-
```bash
46-
magentic ui --rebuild-docker
47-
```
4844
- Make sure you have a stable internet connection.
4945
- Update Docker to the latest version.
5046
- Check that you have enough disk space.
5147
- Try building the images manually:
5248
```bash
53-
docker build -t magentic-ui-vnc-browser:latest ./src/magentic_ui/docker/magentic-ui-browser-docker
54-
docker build -t magentic-ui-python-env:latest ./src/magentic_ui/docker/magentic-ui-python-env
49+
cd docker
50+
sh build-all.sh
5551
```
5652

57-
5853
## 4. 🪟 WSL2 Not Set Up on Windows
5954

6055
**Error:**

docker/build-all.sh

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
#!/bin/bash
2+
3+
CWD="$(pwd)"
4+
if [[ "${CWD##*/}" != "docker" ]]; then
5+
echo "Error: Must run this script from the docker folder."
6+
exit 1
7+
fi
8+
9+
# Run both build scripts in parallel in their respective directories
10+
(
11+
cd magentic-ui-browser-docker && sh build.sh
12+
) &
13+
14+
(
15+
cd magentic-ui-python-env && sh build.sh
16+
) &
17+
18+
wait
19+
echo "Both builds completed."
File renamed without changes.

src/magentic_ui/docker/magentic-ui-browser-docker/build.sh renamed to docker/magentic-ui-browser-docker/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ if [[ "$1" == "--push" ]] || [[ "${PUSH}" == "true" ]]; then
1010
PUSH_FLAG="--push"
1111
echo "Building and pushing images..."
1212
else
13-
echo "Building images locally (use --push flag or set PUSH=true to push to registry)..."
13+
echo "Building images locally..."
1414
fi
1515

1616
docker buildx build \
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)