Re-record StorageSync recorded tests with correct parameter matching

[jongio]

Context

PR #1893 fixed a bug where ParseFromDictionary silently dropped parameters when camelCase names (e.g., incomingTrafficPolicy) didn't match kebab-case option names (e.g., --incoming-traffic-policy). This affected the Should_Crud_storage_sync_service recorded test.

Problem

The existing recording was made when the test's update parameters (incomingTrafficPolicy, identityType) were silently dropped due to the matching bug. The recorded PATCH request body was literally { ""properties"": {} } — a no-op update. The test was passing but never actually testing the update operation.

What was fixed in PR #1893:

1. Test parameter names changed from camelCase to kebab-case to match CLI options
2. [CustomMatcher(compareBody: false)] added temporarily to skip body comparison

Action Required

Re-record the Should_Crud_storage_sync_service test to capture the correct PATCH request body (with identity, incomingTrafficPolicy, and tags fields):

1. Deploy StorageSync test resources: ./eng/scripts/Deploy-TestResources.ps1 -Paths StorageSync
2. Set Record mode in .testsettings.json
3. Run the test: dotnet test tools/Azure.Mcp.Tools.StorageSync/tests/Azure.Mcp.Tools.StorageSync.LiveTests --filter Should_Crud_storage_sync_service
4. Verify new recording has correct PATCH body
5. Push recordings and remove [CustomMatcher(compareBody: false)]

Related

• Fix tool calling with OpenAI Codex models #1893 — Fix Codex model tool calling compatibility
• Tool calling fails with OpenAI Codex models due to JSON Schema incompatibilities #1892 — MCP Server schema issues with Codex models

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ankushbindlish2 @kszobi.