Read default subscription from Azure CLI profile for all subscription-scoped commands by Copilot · Pull Request #1974 · microsoft/mcp

Copilot · 2026-03-09T23:52:22Z

Analyze PR review comments (all 3 unresolved from live1206 were already addressed in prior commit)
Identify merge conflict in SubscriptionListCommand.cs and pipeline failures
Merge main into branch and resolve conflict (keep our SubscriptionInfo model)
Verify auto-merged SubscriptionService.cs correctly uses CacheDurations.Subscription
Fix caching: only cache CLI profile file read (Lazy), keep env var lookup fresh — fixes test failures
Build and test changes (857/858 pass; 1 unrelated network failure)
Run code review

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…cription to guide AI agent behavior The subscription_list tool now: - Returns a SubscriptionInfo model with isDefault field indicating the default subscription (based on AZURE_SUBSCRIPTION_ID environment variable) - Sorts subscriptions so the default appears first in the list - Updated description instructs AI agents to prefer the default subscription or ask the user when no default is set and multiple subscriptions exist Fixes #1079 Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

…cription detection Read the default subscription from ~/.azure/azureProfile.json (set via 'az account set') as the primary source. Fall back to AZURE_SUBSCRIPTION_ID environment variable only if the profile is unavailable. - Add GetDefaultSubscriptionId() to ISubscriptionService interface - Implement ReadDefaultSubscriptionFromAzureProfile in SubscriptionService - Update SubscriptionListCommand to use service method instead of env var directly - Update tool description to reference 'az account set' - Add 6 new profile-reading unit tests - Update existing tests to use mocked GetDefaultSubscriptionId() Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

… into CommandHelper for all subscription-scoped commands - Create AzureCliProfileHelper in Microsoft.Mcp.Core for reading default subscription from ~/.azure/azureProfile.json - Update CommandHelper.GetSubscription() and HasSubscriptionAvailable() to use Azure CLI profile as primary fallback (before AZURE_SUBSCRIPTION_ID env var) - Update SubscriptionService.GetDefaultSubscriptionId() to delegate to shared logic - Update SubscriptionCommand comments to reflect new behavior - Migrate SubscriptionServiceProfileTests to test AzureCliProfileHelper directly Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Copilot

Pull request overview

Updates subscription resolution across subscription-scoped commands to match Azure CLI behavior by reading the default subscription from ~/.azure/azureProfile.json (set via az account set) before falling back to AZURE_SUBSCRIPTION_ID, and surfaces that default selection in subscription list.

Changes:

Added AzureCliProfileHelper and CommandHelper.GetDefaultSubscription() to implement the default-subscription fallback chain.
Updated subscription option validation/resolution to use the shared default-subscription logic.
Updated subscription list to return an isDefault indicator and prioritize the default subscription in the output.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
servers/Azure.Mcp.Server/docs/azmcp-commands.md	Updates CLI docs for `subscription list` to mention `isDefault`.
core/Microsoft.Mcp.Core/src/Helpers/CommandHelper.cs	Adds `GetDefaultSubscription()` and routes subscription resolution/validation through it.
core/Microsoft.Mcp.Core/src/Helpers/AzureCliProfileHelper.cs	New helper to parse Azure CLI profile JSON for the default subscription.
core/Azure.Mcp.Core/src/Services/Azure/Subscription/ISubscriptionService.cs	Adds `GetDefaultSubscriptionId()` to expose shared default-subscription resolution.
core/Azure.Mcp.Core/src/Services/Azure/Subscription/SubscriptionService.cs	Implements `GetDefaultSubscriptionId()` via `CommandHelper`.
core/Azure.Mcp.Core/src/Commands/Subscription/SubscriptionCommand.cs	Updates validation comments to include the new fallback sources.
core/Azure.Mcp.Core/src/Areas/Subscription/Models/SubscriptionInfo.cs	Introduces a model that includes `isDefault` for subscription list output.
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs	Maps subscriptions to `SubscriptionInfo`, marks/sorts the default subscription, and updates description.
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionJsonContext.cs	Adds source-gen serialization metadata for the new output model.
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Subscription/SubscriptionListCommandTests.cs	Extends unit tests to cover default subscription marking/sorting and `isDefault` output.
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Subscription/AzureCliProfileHelperTests.cs	Adds unit tests for parsing the default subscription from Azure CLI profile JSON.

core/Microsoft.Mcp.Core/src/Helpers/CommandHelper.cs

core/Microsoft.Mcp.Core/src/Helpers/AzureCliProfileHelper.cs

core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs

…e, update description - Short-circuit HasSubscriptionAvailable when --subscription option is present (avoid unnecessary file IO) - Only call GetDefaultSubscription() in GetSubscription when value is null/empty/placeholder (lazy evaluation) - Guard GetAzureProfilePath() against empty user profile to avoid relative path reads - Update SubscriptionListCommand description to mention AZURE_SUBSCRIPTION_ID env var fallback Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

live1206

Well-structured PR that cleanly implements Azure CLI profile-based default subscription resolution. The fallback chain (CLI option → CLI profile → env var) is well-designed and the tests are thorough. A few concerns below:

core/Microsoft.Mcp.Core/src/Helpers/CommandHelper.cs

core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs

core/Microsoft.Mcp.Core/src/Helpers/AzureCliProfileHelper.cs

...ure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Subscription/AzureCliProfileHelperTests.cs

…st fragility, add changelog - Cache GetDefaultSubscription() with Lazy<string?> to avoid repeated file I/O - Document intentional sync I/O trade-off in AzureCliProfileHelper - Fix GetAzureProfilePath test to handle null user profile in containers - Add changelog entry for subscription list breaking change Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

…ionListCommand.cs

Only the Azure CLI profile file read (~/.azure/azureProfile.json) is cached with Lazy<string?> since it involves file I/O. The AZURE_SUBSCRIPTION_ID env var lookup is always fresh since it's trivially cheap. This fixes test failures where cached env var values leaked across test cases.

Initial plan

11804a9

Copilot AI assigned Copilot and ArthurMa1978 Mar 9, 2026

github-project-automation bot added this to Azure MCP Server Mar 9, 2026

github-project-automation bot moved this to Untriaged in Azure MCP Server Mar 9, 2026

Copilot started work on behalf of ArthurMa1978 March 9, 2026 23:52 View session

Copilot AI and others added 2 commits March 10, 2026 00:01

Address code review: tighten description and improve sorting readability

5c04535

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix issue with mcp repository according to issue 1079~~ Add isDefault field to subscription_list response and guide AI subscription selection Mar 10, 2026

Copilot finished work on behalf of ArthurMa1978 March 10, 2026 00:08

Copilot started work on behalf of ArthurMa1978 March 10, 2026 07:37 View session

Copilot AI and others added 2 commits March 10, 2026 07:46

Address review: use specific exception types in catch blocks

7c6c198

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Copilot AI changed the title ~~Add isDefault field to subscription_list response and guide AI subscription selection~~ Read default subscription from Azure CLI profile instead of AZURE_SUBSCRIPTION_ID Mar 10, 2026

Copilot finished work on behalf of ArthurMa1978 March 10, 2026 07:52

Copilot started work on behalf of ArthurMa1978 March 10, 2026 10:07 View session

Copilot AI and others added 2 commits March 10, 2026 10:15

Rename test file to match class name AzureCliProfileHelperTests

2c640d6

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>

Copilot AI changed the title ~~Read default subscription from Azure CLI profile instead of AZURE_SUBSCRIPTION_ID~~ Read default subscription from Azure CLI profile for all subscription-scoped commands Mar 10, 2026

Copilot finished work on behalf of ArthurMa1978 March 10, 2026 10:22

ArthurMa1978 marked this pull request as ready for review March 11, 2026 03:28

ArthurMa1978 requested review from a team as code owners March 11, 2026 03:28

ArthurMa1978 requested review from JasonYeMSFT, JonathanCrd, chidozieononiwu, Copilot, joshfree, saikoumudi and vukelich March 11, 2026 03:28

ArthurMa1978 requested a review from alzimmermsft March 11, 2026 03:28

Copilot started reviewing on behalf of ArthurMa1978 March 11, 2026 03:29 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Copilot started work on behalf of ArthurMa1978 March 11, 2026 09:41 View session

Copilot finished work on behalf of ArthurMa1978 March 11, 2026 09:52

ArthurMa1978 linked an issue Mar 16, 2026 that may be closed by this pull request

[BUG] If subscription_list tool called, copilot only uses first response instead of user prompting or other defaults #1079

Closed

live1206 reviewed Mar 17, 2026

View reviewed changes

Copilot started work on behalf of ArthurMa1978 March 17, 2026 09:29 View session

Copilot AI requested a review from ArthurMa1978 March 17, 2026 09:42

Copilot finished work on behalf of ArthurMa1978 March 17, 2026 09:42

Copilot started work on behalf of ArthurMa1978 March 19, 2026 23:37 View session

Copilot AI added 2 commits March 19, 2026 23:42

Merge main into copilot/fix-issue-1079, resolve conflict in Subscript…

412a927

…ionListCommand.cs

Copilot finished work on behalf of ArthurMa1978 March 19, 2026 23:51

live1206 approved these changes Mar 20, 2026

View reviewed changes

ArthurMa1978 merged commit f91bf90 into main Mar 20, 2026
15 checks passed

github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Mar 20, 2026

ArthurMa1978 deleted the copilot/fix-issue-1079 branch March 20, 2026 03:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Read default subscription from Azure CLI profile for all subscription-scoped commands#1974

Read default subscription from Azure CLI profile for all subscription-scoped commands#1974
ArthurMa1978 merged 11 commits intomainfrom
copilot/fix-issue-1079

Copilot AI commented Mar 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

live1206 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

live1206 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Mar 9, 2026 •

edited

Loading