fix: make all moduleResolution values available #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds additional members to the `ModuleResolutionKind` enum to make all
possible `moduleResolution` values available.
the values are based on the enum in `typescriptServices.js`, namely:
```javascript
ModuleResolutionKind = /* @__PURE__ */ ((ModuleResolutionKind3) => {
ModuleResolutionKind3[ModuleResolutionKind3["Classic"] = 1] = "Classic";
ModuleResolutionKind3[ModuleResolutionKind3["NodeJs"] = 2] = "NodeJs";
ModuleResolutionKind3[ModuleResolutionKind3["Node10"] = 2] = "Node10";
ModuleResolutionKind3[ModuleResolutionKind3["Node16"] = 3] = "Node16";
ModuleResolutionKind3[ModuleResolutionKind3["NodeNext"] = 99] = "NodeNext";
ModuleResolutionKind3[ModuleResolutionKind3["Bundler"] = 100] = "Bundler";
return ModuleResolutionKind3;
```
from a developer experience perspective I would actually prefer if the
enum was replaced with the string values that you would use in
`tsconfig.json` as I'd find this more intuitive, but this would be a
larger breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds additional members to the
ModuleResolutionKindenum to make all possiblemoduleResolutionvalues available.the values are based on the enum in
typescriptServices.js, namely:from a developer experience perspective I would actually prefer if the enum was replaced with the string values that you would use in
tsconfig.jsonas I'd find this more intuitive, but this would be a larger breaking change.motivation for this change is that I'm building out a playground for my project and it makes use of the
exportsfield inpackage.jsonfiles which require"moduleResolution": "Node16"https://github.com/mnahkies/openapi-code-generator/blob/main/packages/typescript-koa-runtime/package.json#L18-L39I'm working around by adjusting the
.d.tsfile locations in the virtual filesystem to drop thedistdirectory which makes it work, but it would be nicer if I could just leave them in their original locations / not special case these packages.