Skip to content

Commit

Permalink
Fix breaking issues in Auth and Browshot (#499)
Browse files Browse the repository at this point in the history
* Fixed broken URL string creation in browshot feature

* Rolling back change to skip env auth if no keys set - breaks KV setup

* Allowing skip of env auth method whilst fixing breaking issue

* Return empty list to ChainedTokenCredential

* Liniting fix
  • Loading branch information
petebryan authored Sep 13, 2022
1 parent 057b849 commit 98ffa22
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions msticpy/auth/azure_auth_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,7 @@ def _build_chained_creds(
raise MsticpyAzureConfigError(
"At least one valid authentication method required."
)

return ChainedTokenCredential(*[client for client in clients if client])
return ChainedTokenCredential([client for client in clients if client]) # type: ignore


class _AzCachedConnect:
Expand Down
2 changes: 1 addition & 1 deletion msticpy/context/domain_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def screenshot(url: str, api_key: str = None) -> httpx.Response:
)
image_string = (
f"https://api.browshot.com/api/v1/screenshot/thumbnail?id={bs_id}"
"&zoom=50&key={bs_api_key}"
f"&zoom=50&key={bs_api_key}"
)
# Wait until the screenshot is ready and keep user updated with progress
print("Getting screenshot")
Expand Down
2 changes: 1 addition & 1 deletion requirements-all.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ azure-mgmt-monitor>=2.0.0
azure-mgmt-network>=2.7.0
azure-mgmt-resource>=16.1.0
azure-mgmt-resourcegraph>=8.0.0
azure-mgmt-subscription>=1.0.0
azure-mgmt-subscription>=3.0.0
azure-storage-blob>=12.5.0
bokeh>=1.4.0
cryptography>=3.1
Expand Down

0 comments on commit 98ffa22

Please sign in to comment.