Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Don't Use Memory Attribute Protocol in Core and Optimize SetMemoryAttributes #1132

Open
1 task done
os-d opened this issue Sep 3, 2024 · 0 comments
Open
1 task done
Assignees
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact

Comments

@os-d
Copy link
Contributor

os-d commented Sep 3, 2024

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

There is an instance of GetMemoryAttributes in DxeCore to avoid calling SetMemoryAttributes if no attributes are different. The memory attribute protocol should only be used by bootloaders or other non-core components. To not lose the performance gain, add smarts to SetMemoryAttribute to only go down the set path if the attributes are not the same.

Expected Behavior

n/a

Steps To Reproduce

n/a

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:

Version Information

top of tree

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@os-d os-d added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Sep 3, 2024
@os-d os-d self-assigned this Sep 3, 2024
@github-actions github-actions bot added urgency:low Little to no impact labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Development

No branches or pull requests

1 participant