Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: tools_def parser does not support inline comment #1193

Open
1 task done
kuqin12 opened this issue Oct 23, 2024 · 0 comments
Open
1 task done

[Bug]: tools_def parser does not support inline comment #1193

kuqin12 opened this issue Oct 23, 2024 · 0 comments
Labels
state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact

Comments

@kuqin12
Copy link
Contributor

kuqin12 commented Oct 23, 2024

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

The current tools_def parser does not take inline comments as expected, and treating it as an additional argument and piped into the final build arguments.

We have been lucky as most of the inline comments are hidden behind existing comments. And other toolchains like CLANG do not get built often.

Expected Behavior

Properly treat inline comments as legit comments instead of piping into the final comments.

Steps To Reproduce

Add some inline comments (i.e. # MU_CHANGE) to the tools_def.txt in conf folder for the target build, i.e. PP_FLAGS. The build could break with #: No such file or directory.

Build Environment

  • OS(s): WSL
  • Tool Chain(s): GCC5
  • Targets Impacted: AARCH64

Version Information

Top of tree.

Urgency

Low

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@kuqin12 kuqin12 added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Oct 23, 2024
@github-actions github-actions bot added urgency:low Little to no impact state:needs-owner Needs an issue owner to be assigned labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Development

No branches or pull requests

1 participant