Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTools/Plugin/FlattenPdbs: Add plugin #933

Merged

Conversation

makubacki
Copy link
Member

Description

A build plugin that copies all PDB file to a single directory this
can make publishing symbols easier and reduce the size of modules
using ALT PDB path.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • Verify the plugin copies PDB files to the PDB directory in the
    build output directory as expected.

Integration Instructions

No specific work needed. PDBs will be copied to a PDB directory in
build output.

@makubacki makubacki added the type:feature-request A new feature proposal label Jun 19, 2024
@makubacki makubacki self-assigned this Jun 19, 2024
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Jun 19, 2024
@makubacki makubacki enabled auto-merge (rebase) June 21, 2024 17:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@a941de4). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #933   +/-   ##
=================================================
  Coverage                  ?   38.29%           
=================================================
  Files                     ?      207           
  Lines                     ?    28463           
  Branches                  ?     6980           
=================================================
  Hits                      ?    10901           
  Misses                    ?    17497           
  Partials                  ?       65           
Flag Coverage Δ
MdeModulePkg 17.80% <ø> (?)
MdePkg 51.59% <ø> (?)
NetworkPkg 8.51% <ø> (?)
UefiCpuPkg 28.75% <ø> (?)
UnitTestFrameworkPkg 6.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A build plugin that copies all PDB file to a single directory this
can make publishing symbols easier and reduce the size of modules
using ALT PDB path.

Co-authored-by: Bret Barkelew <[email protected]>
Co-authored-by: Joey Vagedes <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki merged commit d312586 into microsoft:release/202405 Jun 21, 2024
33 checks passed
@makubacki makubacki linked an issue Jun 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code type:feature-request A new feature proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: FlattenPdbs Plugin
4 participants