Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQUASH ON REBASE] Move inline comments to separate lines for tools_def #1190

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Oct 22, 2024

Description

The existing change somehow will make the PP_FLAGS have # MU_CHANGE embedded, causing the build to fail:

"PP_FLAGS" : -E -x assembler-with-cpp -include AutoGen.h # MU_CHANGE -I

This change removed applicable inline comments. But the real change should probably come from the parser.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This change was tested on the failing system and this fixed it.

Integration Instructions

N/A

@kuqin12 kuqin12 requested review from Javagedes, os-d and cfernald and removed request for Javagedes and os-d October 22, 2024 23:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.59%. Comparing base (0ba6a3d) to head (2b71c06).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1190   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362501   362501           
  Branches         5632     5632           
===========================================
  Hits             5776     5776           
  Misses         356618   356618           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki added the type:bug Something isn't working label Oct 23, 2024
Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark this as [SQUASH ON REBASE]?

@makubacki
Copy link
Member

Mark this as [SQUASH ON REBASE]?

I think so. What is the plan for catching this in the future? The PR description mentions updating the parser. If that's what is going to be done is that tracked somewhere?

@kuqin12
Copy link
Contributor Author

kuqin12 commented Oct 23, 2024

Mark this as [SQUASH ON REBASE]?

I think so. What is the plan for catching this in the future? The PR description mentions updating the parser. If that's what is going to be done is that tracked somewhere?

noup :) i was expecting someone to pick up that work. but i will create an issue before merging this.

@kuqin12 kuqin12 changed the title Move inline comments to separate lines for tools_def [SQUASH ON REBASE] Move inline comments to separate lines for tools_def Oct 23, 2024
@kuqin12
Copy link
Contributor Author

kuqin12 commented Oct 23, 2024

Created #1193 to track the potential parser change.

@kuqin12 kuqin12 merged commit be8654d into microsoft:dev/202405 Oct 23, 2024
35 checks passed
@kuqin12 kuqin12 deleted the no_inline branch October 23, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants