From 97be452c1c2df8e381262a1b5e234bca87c84e9a Mon Sep 17 00:00:00 2001
From: Freddy Kristiansen <freddy.kristiansen@microsoft.com>
Date: Tue, 21 Nov 2023 16:21:44 +0100
Subject: [PATCH] add parameter to replace versionnumber (#3240)

Fixes #3229

---------

Co-authored-by: freddydk <freddydk@users.noreply.github.com>
---
 AppHandling/Replace-DependenciesInAppFile.ps1 | 17 ++++++++++++++---
 ReleaseNotes.txt                              |  3 ++-
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/AppHandling/Replace-DependenciesInAppFile.ps1 b/AppHandling/Replace-DependenciesInAppFile.ps1
index dc40635d3..c750923f7 100644
--- a/AppHandling/Replace-DependenciesInAppFile.ps1
+++ b/AppHandling/Replace-DependenciesInAppFile.ps1
@@ -13,6 +13,10 @@
   An Array of hashtable, containing id, name and publisher of an app, which should be added to internals Visible to
  .Parameter showMyCode
   With this parameter you can change or check ShowMyCode in the app file. Check will throw an error if ShowMyCode is False.
+ .Parameter replacePackageId
+  Add this switch to replace the package id of the app file with a new GUID
+ .Parameter replaceVersionNumber
+  Add this parameter to replace the version number of the app file with this version number
  .Example
   Replace-DependenciesInAppFile -containerName test -Path c:\temp\myapp.app -replaceDependencies @{ "437dbf0e-84ff-417a-965d-ed2bb9650972" = @{ "id" = "88b7902e-1655-4e7b-812e-ee9f0667b01b"; "name" = "MyBaseApp"; "publisher" = "Freddy Kristiansen"; "minversion" = "1.0.0.0" }}
  .Example
@@ -28,6 +32,7 @@ Function Replace-DependenciesInAppFile {
         [ValidateSet('Ignore','True','False','Check')]
         [string] $ShowMyCode = "Ignore",
         [switch] $replacePackageId,
+        [string] $replaceVersionNumber,
         [HashTable[]] $internalsVisibleTo = $null
     )
 
@@ -39,7 +44,7 @@ try {
         $path = $Destination
     }
     
-    Invoke-ScriptInBCContainer -containerName $containerName -scriptBlock { Param($path, $Destination, $replaceDependencies, $ShowMyCode, $replacePackageId, $internalsVisibleTo)
+    Invoke-ScriptInBCContainer -containerName $containerName -scriptBlock { Param($path, $Destination, $replaceDependencies, $ShowMyCode, $replacePackageId, $replaceVersionNumber, $internalsVisibleTo)
     
         add-type -path (Get-Item "C:\Program Files\Microsoft Dynamics NAV\*\Service\system.io.packaging.dll").FullName
     
@@ -155,13 +160,19 @@ try {
                 }
             }
 
+            if ($replaceVersionNumber) {
+                Write-Host "Replacing Version Number with $replaceVersionNumber"
+                $manifest.Package.App.Version = $replaceVersionNumber
+                $manifestChanges = $true
+            }
+
             if ($replacePackageId) {
+                Write-Host "Replacing Package ID with new GUID"
                 $packageId = [Guid]::NewGuid()
                 $manifestChanges = $true
             }
     
             if ($manifestChanges) {
-    
                 $partStream = $manifestPart.GetStream([System.IO.FileMode]::Create)
                 $manifest.Save($partStream)
                 $partStream.Flush()
@@ -208,7 +219,7 @@ try {
                 $fs.Close()
             }
         }
-    } -argumentList (Get-BCContainerPath -containerName $containerName -path $path -throw), (Get-BCContainerPath -containerName $containerName -path $Destination -throw), $replaceDependencies, $ShowMyCode, $replacePackageId, $internalsVisibleTo
+    } -argumentList (Get-BCContainerPath -containerName $containerName -path $path -throw), (Get-BCContainerPath -containerName $containerName -path $Destination -throw), $replaceDependencies, $ShowMyCode, $replacePackageId, $replaceVersionNumber, $internalsVisibleTo
 }
 catch {
     TrackException -telemetryScope $telemetryScope -errorRecord $_
diff --git a/ReleaseNotes.txt b/ReleaseNotes.txt
index e9ed73d50..7a76d03b2 100644
--- a/ReleaseNotes.txt
+++ b/ReleaseNotes.txt
@@ -5,7 +5,8 @@ New-AppSourceSubmission obsoleted parameter -doNotCheckVersionNumber that was pr
 Issue 3219 Run-AlValidation cannot validate against Next Major without an insider Sas token
 Do not attempt to call Get-BcContainerAppInfo if we are using filesonly containers in Run-AlPipeline
 Do not attempt to download unknown symbols from filesonly containers
-Add paramater generateErrorLog to Compile-AppInNavContainer
+Add parameter generateErrorLog to Compile-AppInNavContainer
+Issue 3229 Add parameter replaceVersionNumber to Replace-DependenciesInAppFile
 
 6.0.0
 Add parameter -accept_insiderEULA on New-BcContainer, Get-BcArtifactUrl and Run-AlPipeline to accept the insider EULA (https://go.microsoft.com/fwlink/?linkid=2245051) instead of using the insider SAS token.