Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we have a plan to support macOS? #32

Open
ntbps opened this issue Oct 10, 2019 · 3 comments
Open

Do we have a plan to support macOS? #32

ntbps opened this issue Oct 10, 2019 · 3 comments

Comments

@ntbps
Copy link

ntbps commented Oct 10, 2019

Do we have a plan to support macOS?
@simonxiaoss
Copy link
Member

Bluecoca, has a PR to support macOS here: #19
I don't have a test environment to test the PR so I did not merge it yet.

@thanasisk
Copy link
Contributor

@simonxiaoss If i test on FreeBSD, will you merge the request?

@simonxiaoss
Copy link
Member

Yes, sure. I just want to have a graceful way to support multiple platforms. At least, the #ifdef in main line of the code is not acceptable to me. Maybe we should define abstract functions and then have different implementations for different platforms.

I want the main line of the code is still readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thanasisk @ntbps @simonxiaoss