Initialize Objective-C bindings #709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyline75489
commented
Jul 18, 2024
edgchen1
reviewed
Jul 22, 2024
skottmckay
reviewed
Aug 27, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
edgchen1
reviewed
Oct 21, 2024
skyline75489
commented
Oct 23, 2024
edgchen1
reviewed
Oct 24, 2024
edgchen1
reviewed
Oct 25, 2024
edgchen1
reviewed
Oct 28, 2024
|
|
||
| s.vendored_frameworks = "@ORTGENAI_C_FRAMEWORK@" | ||
| s.static_framework = true | ||
| s.framework = ['ImageIO', 'CoreGraphics'] |
There was a problem hiding this comment.
why link to these frameworks? does anything in ort-genai depend on them? if not, should the decision to depend on them be left to the user?
There was a problem hiding this comment.
yes ort-genai requires ImageIO and CoreGraphics for image decoding.
edgchen1
reviewed
Oct 28, 2024
Comment on lines
+128
to
+132
| snapshot_download( | ||
| repo_id="microsoft/Phi-3-mini-4k-instruct-onnx", | ||
| allow_patterns="cpu_and_mobile/cpu-int4-rtn-block-32-acc-level-4/*", | ||
| local_dir=model_dir | ||
| ) |
There was a problem hiding this comment.
where is this model used?
There was a problem hiding this comment.
I didn't check in the actual testing code, because it's quite large. I copied the apple_pacakge_test in ORT and started from there. The actual testing code requires this model. I'll create another PR after this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains Objective-C wrapper code, podspec generation infras and the accompanying test code.
Internal workitem: https://task.ms/aii/35199