Skip to content

Commit

Permalink
Fix build break in macos (#3046)
Browse files Browse the repository at this point in the history
  • Loading branch information
yufenglee authored Feb 20, 2020
1 parent 5e594a0 commit a8efa42
Show file tree
Hide file tree
Showing 18 changed files with 7 additions and 78 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ jobs:
workspace:
clean: all
pool:
vmImage: 'macOS-10.13'
vmImage: 'macOS-10.14'
strategy:
matrix:
Python35:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
workspace:
clean: all
pool:
vmImage: 'macOS-10.13'
vmImage: 'macOS-10.14'
steps:
- template: templates/mac-set-variables-and-download.yml
- template: templates/set-version-number-variables-step.yml
Expand Down
1 change: 0 additions & 1 deletion tools/ci_build/github/azure-pipelines/mac-ci-pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
jobs:
- template: templates/mac-ci.yml
parameters:
AgentPool : 'Hosted macOS High Sierra'
DoNugetPack: 'false'
BuildCommand: 'python3 $(Build.SourcesDirectory)/tools/ci_build/build.py --use_openmp --build_dir $(Build.BinariesDirectory) --build_wheel --skip_submodule_sync --use_automl --parallel --build_shared_lib --build_java --enable_language_interop_ops --enable_onnx_tests --config Debug RelWithDebInfo'
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ variables:
jobs:
- job: MacOS_CI_Dev
pool:
vmImage: 'macOS-10.13'
vmImage: 'macOS-10.14'
steps:
- template: templates/set-test-data-variables-step.yml
- task: CmdLine@2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

schedules:
- cron: "0 8 * * *"
displayName: Daily Build
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

schedules:
- cron: "0 10 * * *"
displayName: Daily Build
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

variables:
PackageName: 'Microsoft.ML.OnnxRuntime.MKLML'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

schedules:
- cron: "0 14 * * *"
displayName: Daily Build
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

variables:
DisableContribOps: 'ON'

Expand Down
6 changes: 0 additions & 6 deletions tools/ci_build/github/azure-pipelines/nuget/cpu-pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

jobs:
- template: templates/cpu.yml
parameters:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU-CUDA10'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

schedules:
- cron: "0 8 * * *"
displayName: Daily Build
Expand Down
6 changes: 0 additions & 6 deletions tools/ci_build/github/azure-pipelines/nuget/gpu-pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU-CUDA10'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

variables:
PackageName: 'Microsoft.ML.OnnxRuntime.Gpu'
TESTONGPU: 'ON'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

parameters:
DoEsrp: 'false'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

parameters:
DoEsrp: 'false'

Expand Down
6 changes: 0 additions & 6 deletions tools/ci_build/github/azure-pipelines/nuget/templates/cpu.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

parameters:
DoEsrp: 'false'
DoCompliance: 'false'
Expand Down
6 changes: 0 additions & 6 deletions tools/ci_build/github/azure-pipelines/nuget/templates/gpu.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# Defined as pipeline variables
# variables:
# AgentPoolWin : 'Win-CPU-CUDA10'
# AgentPoolLinux : 'Linux-CPU'
# AgentPoolMacOS : 'macOS-10.13'

parameters:
DoEsrp: 'false'
PackageName: 'Microsoft.ML.OnnxRuntime.Gpu'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ jobs:
- job: NuGet_Test_MacOS
workspace:
clean: all
pool: ${{ parameters.AgentPool }}
pool:
vmImage: 'macOS-10.14'
dependsOn:
- NuGet_Packaging
condition: succeeded()
Expand Down
3 changes: 2 additions & 1 deletion tools/ci_build/github/azure-pipelines/templates/mac-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ jobs:
workspace:
clean: all
timeoutInMinutes: 120
pool: ${{ parameters.AgentPool }}
pool:
vmImage: 'macOS-10.14'
variables:
BuildCommand: ${{ parameters.BuildCommand }}
steps:
Expand Down

0 comments on commit a8efa42

Please sign in to comment.