-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ORT Performance threading docs #16995
Conversation
Update ORT Performance threading docs. Clearer defaults, clearer explanation of INTRA thread behavior. Document spinning. Provide links to APIs
For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fixes for PR review 1
@pranavsharma How should we handle this? Can you force merge the PR OR should we move this OR do you have a better working URL? |
Gentle ping @pranavsharma
Gentle ping @pranavsharma |
Hi @natke - Can this PR be merged ? Also, I don't see a 404 for this URL (https://github.com/microsoft/onnx-converters-private/issues/new/choose) anymore, I guess that link is up and running now ? |
Thank you @ivberg! |
Description
Update ORT Performance threading docs. Clearer defaults, clearer explanation of INTRA thread behavior. Document spinning. Provide links to APIs
Motivation and Context
After discussion with ORT Performance team and in-depth testing of these settings. It was determined that docs were not clear, misleading at times, or needed missing info.