Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made genai tutorials direct onnx tutorial links. + added goodnotes testimonial #22311

Merged

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Oct 4, 2024

At some point will need to merge cards + testimonials objects to be one.

As always, preview at: https://maanavd.github.io/onnxruntime/

Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes for the Hugging Face and Goodnotes testimonials are now the same, so I think one of them is incorrect.

Also, it's unclear what the "Accelerated Inference API" is, so it may be worth linking if that's a publicly accessible product they work on (or removing the "...and accelerate private models..." part of the sentence.

sophies927
sophies927 previously approved these changes Oct 7, 2024
Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just made the tiniest syntax suggestion for formatting purposes.

src/routes/testimonials/+page.svelte Outdated Show resolved Hide resolved
@parinitarahi
Copy link
Contributor

Approved

@MaanavD MaanavD merged commit 36db78c into microsoft:gh-pages Oct 8, 2024
2 checks passed
@MaanavD MaanavD deleted the goodreads_testimonial_and_genai_updates branch October 8, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants