Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

olive shared cache blog init #22642

Merged
merged 5 commits into from
Oct 31, 2024
Merged

olive shared cache blog init #22642

merged 5 commits into from
Oct 31, 2024

Conversation

samuel100
Copy link
Contributor

Added blog post on Olive's shared cache feature.

MaanavD
MaanavD reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@MaanavD MaanavD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments, looks great to me! After they're addressed, I think it's good to ship. 1-2 more reviews do sound like a good idea however.

Generally though, it reads incredibly clearly and is direct and to the point! Love it 💯

src/routes/blogs/+page.svelte Outdated Show resolved Hide resolved
src/routes/blogs/olive-shared-cache/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/olive-shared-cache/+page.svx Outdated Show resolved Hide resolved
src/routes/blogs/olive-shared-cache/+page.svx Show resolved Hide resolved
MaanavD
MaanavD approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@MaanavD MaanavD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@MaanavD MaanavD merged commit 3733e39 into microsoft:gh-pages Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devang-ml devang-ml devang-ml approved these changes

@MaanavD MaanavD MaanavD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuel100 @MaanavD @devang-ml