Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complicated ops are not well-covered by extra_opinfo #1274

Closed
titaiwangms opened this issue Feb 8, 2024 · 0 comments
Closed

Complicated ops are not well-covered by extra_opinfo #1274

titaiwangms opened this issue Feb 8, 2024 · 0 comments
Assignees
Labels
topic: testing topic: torch_lib Related to the torch/aten function lib in development

Comments

@titaiwangms
Copy link
Contributor

titaiwangms commented Feb 8, 2024

For example, #1271. In FFT family, we are not relying on torch op tests from PyTorch, so in some complicated ops, such as FFTs, layer_norm, upsampling, etc.., are passing tests in onnxscript, but failing in torch ops test. To avoid back and forth fixing the ops, we should have test_fx_op_consistency to enable integration tests in onnxscript for these complicated ops.

@titaiwangms titaiwangms added the topic: torch_lib Related to the torch/aten function lib in development label Feb 8, 2024
@titaiwangms titaiwangms self-assigned this Feb 8, 2024
@titaiwangms titaiwangms closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: testing topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

No branches or pull requests

2 participants