Fix some private items are also public (#323)

* fix create item with isPrivate not work issue

* Fix both is private and is public

* Add comments

Author: yiyione

rest_server/src/models/marketplace_item.js

@@ -246,6 +246,18 @@ class MarketplaceItem {
 
   async create(itemReq) {
     const handler = modelSyncHandler(async itemReq => {
+      // Item's 3 different cases:
+      // 1. Share to all users (isPublic: true)
+      // 2. Private (isPrivate: true)
+      // 3. Share to some specific groups (isPublic: false & isPrivate: false)
+      if (itemReq.isPrivate) {
+        itemReq.isPublic = false;
+        itemReq.groupList = [];
+      } else if (itemReq.isPublic) {
+        itemReq.isPrivate = false;
+        itemReq.groupList = [];
+      }
+
       const item = await this.orm.create(itemReq);
       return item.id;
     });