chore(roll): roll Playwright to 1.35.0-beta-1686247644000 (#1964)

Author: mxschmitt

README.md

@@ -4,7 +4,7 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->114.0.5735.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->115.0.5790.24<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | WebKit <!-- GEN:webkit-version -->16.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | Firefox <!-- GEN:firefox-version -->113.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 

playwright/_impl/_browser_context.py

@@ -232,13 +232,19 @@ def _on_binding(self, binding_call: BindingCall) -> None:
         asyncio.create_task(binding_call.call(func))
 
     def set_default_navigation_timeout(self, timeout: float) -> None:
-        self._timeout_settings.set_navigation_timeout(timeout)
+        return self._set_default_navigation_timeout_impl(timeout)
+
+    def _set_default_navigation_timeout_impl(self, timeout: Optional[float]) -> None:
+        self._timeout_settings.set_default_navigation_timeout(timeout)
         self._channel.send_no_reply(
             "setDefaultNavigationTimeoutNoReply", dict(timeout=timeout)
         )
 
     def set_default_timeout(self, timeout: float) -> None:
-        self._timeout_settings.set_timeout(timeout)
+        return self._set_default_timeout_impl(timeout)
+
+    def _set_default_timeout_impl(self, timeout: Optional[float]) -> None:
+        self._timeout_settings.set_default_timeout(timeout)
         self._channel.send_no_reply("setDefaultTimeoutNoReply", dict(timeout=timeout))
 
     @property

playwright/_impl/_element_handle.py

@@ -287,6 +287,7 @@ async def screenshot(
         caret: Literal["hide", "initial"] = None,
         scale: Literal["css", "device"] = None,
         mask: List["Locator"] = None,
+        mask_color: str = None,
     ) -> bytes:
         params = locals_to_params(locals())
         if "path" in params:

playwright/_impl/_helper.py

@@ -177,27 +177,35 @@ class HarLookupResult(TypedDict, total=False):
 class TimeoutSettings:
     def __init__(self, parent: Optional["TimeoutSettings"]) -> None:
         self._parent = parent
-        self._timeout: Optional[float] = None
-        self._navigation_timeout: Optional[float] = None
+        self._default_timeout: Optional[float] = None
+        self._default_navigation_timeout: Optional[float] = None
 
-    def set_timeout(self, timeout: float) -> None:
-        self._timeout = timeout
+    def set_default_timeout(self, timeout: Optional[float]) -> None:
+        self._default_timeout = timeout
 
     def timeout(self, timeout: float = None) -> float:
         if timeout is not None:
             return timeout
-        if self._timeout is not None:
-            return self._timeout
+        if self._default_timeout is not None:
+            return self._default_timeout
         if self._parent:
             return self._parent.timeout()
         return 30000
 
-    def set_navigation_timeout(self, navigation_timeout: float) -> None:
-        self._navigation_timeout = navigation_timeout
+    def set_default_navigation_timeout(
+        self, navigation_timeout: Optional[float]
+    ) -> None:
+        self._default_navigation_timeout = navigation_timeout
+
+    def default_navigation_timeout(self) -> Optional[float]:
+        return self._default_navigation_timeout
+
+    def default_timeout(self) -> Optional[float]:
+        return self._default_timeout
 
     def navigation_timeout(self) -> float:
-        if self._navigation_timeout is not None:
-            return self._navigation_timeout
+        if self._default_navigation_timeout is not None:
+            return self._default_navigation_timeout
         if self._parent:
             return self._parent.navigation_timeout()
         return 30000

playwright/_impl/_locator.py

@@ -524,6 +524,7 @@ async def screenshot(
         caret: Literal["hide", "initial"] = None,
         scale: Literal["css", "device"] = None,
         mask: List["Locator"] = None,
+        mask_color: str = None,
     ) -> bytes:
         params = locals_to_params(locals())
         return await self._with_element(

playwright/_impl/_network.py

@@ -422,6 +422,7 @@ async def continue_route() -> None:
                 if "headers" in params:
                     params["headers"] = serialize_headers(params["headers"])
                 params["requestUrl"] = self.request._initializer["url"]
+                params["isFallback"] = is_internal
                 await self._connection.wrap_api_call(
                     lambda: self._race_with_page_close(
                         self._channel.send(

playwright/_impl/_page.py

@@ -323,13 +323,13 @@ def frames(self) -> List[Frame]:
         return self._frames.copy()
 
     def set_default_navigation_timeout(self, timeout: float) -> None:
-        self._timeout_settings.set_navigation_timeout(timeout)
+        self._timeout_settings.set_default_navigation_timeout(timeout)
         self._channel.send_no_reply(
             "setDefaultNavigationTimeoutNoReply", dict(timeout=timeout)
         )
 
     def set_default_timeout(self, timeout: float) -> None:
-        self._timeout_settings.set_timeout(timeout)
+        self._timeout_settings.set_default_timeout(timeout)
         self._channel.send_no_reply("setDefaultTimeoutNoReply", dict(timeout=timeout))
 
     async def query_selector(
@@ -641,6 +641,7 @@ async def screenshot(
         caret: Literal["hide", "initial"] = None,
         scale: Literal["css", "device"] = None,
         mask: List["Locator"] = None,
+        mask_color: str = None,
     ) -> bytes:
         params = locals_to_params(locals())
         if "path" in params:
@@ -957,13 +958,25 @@ def request(self) -> "APIRequestContext":
         return self.context.request
 
     async def pause(self) -> None:
-        await asyncio.wait(
-            [
-                asyncio.create_task(self._browser_context._pause()),
-                self._closed_or_crashed_future,
-            ],
-            return_when=asyncio.FIRST_COMPLETED,
+        default_navigation_timeout = (
+            self._browser_context._timeout_settings.default_navigation_timeout()
         )
+        default_timeout = self._browser_context._timeout_settings.default_timeout()
+        self._browser_context.set_default_navigation_timeout(0)
+        self._browser_context.set_default_timeout(0)
+        try:
+            await asyncio.wait(
+                [
+                    asyncio.create_task(self._browser_context._pause()),
+                    self._closed_or_crashed_future,
+                ],
+                return_when=asyncio.FIRST_COMPLETED,
+            )
+        finally:
+            self._browser_context._set_default_navigation_timeout_impl(
+                default_navigation_timeout
+            )
+            self._browser_context._set_default_timeout_impl(default_timeout)
 
     async def pdf(
         self,

playwright/_impl/_set_input_files_helpers.py

@@ -33,26 +33,26 @@ async def convert_input_files(
 ) -> InputFilesList:
     file_list = files if isinstance(files, list) else [files]
 
-    has_large_buffer = any(
-        [
-            len(f.get("buffer", "")) > SIZE_LIMIT_IN_BYTES
-            for f in file_list
-            if not isinstance(f, (str, Path))
-        ]
+    total_buffer_size_exceeds_limit = (
+        sum(
+            [
+                len(f.get("buffer", ""))
+                for f in file_list
+                if not isinstance(f, (str, Path))
+            ]
+        )
+        > SIZE_LIMIT_IN_BYTES
     )
-    if has_large_buffer:
+    if total_buffer_size_exceeds_limit:
         raise Error(
             "Cannot set buffer larger than 50Mb, please write it to a file and pass its path instead."
         )
 
-    has_large_file = any(
-        [
-            os.stat(f).st_size > SIZE_LIMIT_IN_BYTES
-            for f in file_list
-            if isinstance(f, (str, Path))
-        ]
+    total_file_size_exceeds_limit = (
+        sum([os.stat(f).st_size for f in file_list if isinstance(f, (str, Path))])
+        > SIZE_LIMIT_IN_BYTES
     )
-    if has_large_file:
+    if total_file_size_exceeds_limit:
         if context._channel._connection.is_remote:
             streams = []
             for file in file_list: