Skip to content

Commit a024162

Browse files
dgozmandgozman
authored
chore(ci): remove flakiness dashboard upload and json reporter (#42670)
1 parent cca996e commit a024162

14 files changed

Lines changed: 0 additions & 136 deletions

File tree

‎.github/actions/run-test/action.yml‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,6 @@ inputs:
2626
description: 'Shell to use'
2727
required: false
2828
default: 'bash'
29-
flakiness-client-id:
30-
description: 'Azure Flakiness Dashboard Client ID'
31-
required: false
32-
flakiness-tenant-id:
33-
description: 'Azure Flakiness Dashboard Tenant ID'
34-
required: false
35-
flakiness-subscription-id:
36-
description: 'Azure Flakiness Dashboard Subscription ID'
37-
required: false
3829

3930
runs:
4031
using: composite
@@ -80,19 +71,6 @@ runs:
8071
shell: ${{ inputs.shell }}
8172
env:
8273
PW_TAG: "@${{ inputs.bot-name }}"
83-
- name: Azure Login
84-
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
85-
if: ${{ !cancelled() && env.PLAYWRIGHT_SETUP_COMPLETE == 'true' && github.event_name == 'push' && github.repository == 'microsoft/playwright' }}
86-
with:
87-
client-id: ${{ inputs.flakiness-client-id }}
88-
tenant-id: ${{ inputs.flakiness-tenant-id }}
89-
subscription-id: ${{ inputs.flakiness-subscription-id }}
90-
- run: |
91-
echo "::group::./utils/upload_flakiness_dashboard.sh"
92-
./utils/upload_flakiness_dashboard.sh ./test-results/report.json
93-
echo "::endgroup::"
94-
if: ${{ !cancelled() && env.PLAYWRIGHT_SETUP_COMPLETE == 'true' }}
95-
shell: bash
9674
- name: Upload blob report
9775
if: ${{ !cancelled() && env.PLAYWRIGHT_SETUP_COMPLETE == 'true' && (github.event_name == 'pull_request' || failure()) }}
9876
uses: ./.github/actions/upload-blob-report

‎.github/workflows/tests_bidi.yml‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,6 @@ jobs:
7070
path: test-results/report.csv
7171
retention-days: 7
7272

73-
- name: Upload json report to GitHub
74-
if: ${{ !cancelled() }}
75-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
76-
with:
77-
name: json-report-${{ matrix.channel }}
78-
path: test-results/report.json
79-
retention-days: 7
80-
8173
- name: Upload parquet report
8274
if: ${{ !cancelled() }}
8375
uses: ./.github/actions/upload-parquet-report

‎.github/workflows/tests_docker.yml‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ jobs:
3737
id-token: write # This is required for OIDC login (azure/login) to succeed
3838
contents: read # This is required for actions/checkout to succeed
3939
steps:
40-
- name: Create ~/.azure directory
41-
run: mkdir -p ~/.azure
4240
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
4341
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
4442
with:
@@ -74,7 +72,6 @@ jobs:
7472
--workdir /home/pwuser \
7573
--env CI \
7674
--env INSIDE_DOCKER=1 \
77-
-v ~/.azure:/root/.azure \
7875
-d \
7976
-t \
8077
playwright:localbuild /bin/bash
@@ -112,29 +109,6 @@ jobs:
112109
--env GITHUB_SHA \
113110
--workdir /home/pwuser/playwright docker-tests xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" npm run test -- --grep "@smoke"
114111
115-
- name: Azure Login
116-
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }}
117-
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
118-
with:
119-
client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
120-
tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
121-
subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
122-
- name: Upload Flakiness dashboard
123-
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }}
124-
run: |
125-
# Flakiness dashboard has to be uploaded from-inside docker container so that it can collect meta information, e.g. arch
126-
# See https://github.com/microsoft/playwright/blob/13b1e52d95df416fdfa7846c8a840aad8df263af/utils/upload_flakiness_dashboard.sh#L71-L86
127-
docker exec \
128-
--env GITHUB_REPOSITORY \
129-
--env GITHUB_REF \
130-
--env GITHUB_RUN_ID \
131-
--user root \
132-
--workdir /home/pwuser/playwright docker-tests /bin/bash -c '
133-
set -e
134-
# Azure-CLI is needed for upload_flakiness_dashboard.sh script.
135-
curl -sL https://aka.ms/InstallAzureCLIDeb | bash
136-
./utils/upload_flakiness_dashboard.sh "./test-results/report.json"
137-
'
138112
- name: Copy blob report from container
139113
if: ${{ !cancelled() && (github.event_name == 'pull_request' || failure()) }}
140114
run: docker cp "docker-tests:/home/pwuser/playwright/blob-report" "./blob-report"

‎.github/workflows/tests_mcp.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ env:
3131
jobs:
3232
test_mcp:
3333
name: ${{ matrix.os }} - ${{ matrix.project }}
34-
# Used for authentication of flakiness upload
35-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
3634
strategy:
3735
fail-fast: false
3836
matrix:
@@ -51,7 +49,6 @@ jobs:
5149
project: msedge
5250
runs-on: ${{ matrix.os }}
5351
permissions:
54-
id-token: write # This is required for OIDC login (azure/login) to succeed
5552
contents: read # This is required for actions/checkout to succeed
5653
steps:
5754
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
@@ -60,6 +57,3 @@ jobs:
6057
node-version: "22"
6158
command: npm run test-mcp -- --project=${{ matrix.project }}
6259
bot-name: "mcp-${{ matrix.os }}-${{ matrix.project }}"
63-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
64-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
65-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}

‎.github/workflows/tests_primary.yml‎

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ env:
3232
jobs:
3333
test_linux:
3434
name: ${{ matrix.os }} (${{ matrix.browser }} - Node.js ${{ matrix.node-version }})
35-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
3635
strategy:
3736
fail-fast: false
3837
matrix:
@@ -51,7 +50,6 @@ jobs:
5150
browser: chromium
5251
runs-on: ${{ matrix.os }}
5352
permissions:
54-
id-token: write # This is required for OIDC login (azure/login) to succeed
5553
contents: read # This is required for actions/checkout to succeed
5654
steps:
5755
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
@@ -61,13 +59,9 @@ jobs:
6159
browsers-to-install: ${{ matrix.browser }} chromium
6260
command: npm run test -- --project=${{ matrix.browser }}-*
6361
bot-name: "${{ matrix.browser }}-${{ matrix.os }}-node${{ matrix.node-version }}"
64-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
65-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
66-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
6762

6863
test_test_runner:
6964
name: Test Runner
70-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
7165
strategy:
7266
fail-fast: false
7367
matrix:
@@ -124,7 +118,6 @@ jobs:
124118
shardWeights: '58:42'
125119
runs-on: ${{ matrix.os }}
126120
permissions:
127-
id-token: write # This is required for OIDC login (azure/login) to succeed
128121
contents: read # This is required for actions/checkout to succeed
129122
steps:
130123
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
@@ -134,17 +127,12 @@ jobs:
134127
command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
135128
bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}"
136129
shard-index: ${{ matrix.shardIndex }}
137-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
138-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
139-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
140130
env:
141131
PWTEST_SHARD_WEIGHTS: ${{ matrix.shardWeights }}
142132

143133
test_web_components:
144134
name: Web Components - ${{ matrix.package }}
145-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
146135
permissions:
147-
id-token: write # This is required for OIDC login (azure/login) to succeed
148136
contents: read # This is required for actions/checkout to succeed
149137
strategy:
150138
fail-fast: false
@@ -159,9 +147,6 @@ jobs:
159147
browsers-to-install: chromium
160148
command: npm run test-${{ matrix.package }}
161149
bot-name: "web-components-${{ matrix.package }}"
162-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
163-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
164-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
165150

166151
test_vscode_extension:
167152
name: VSCode Extension
@@ -201,7 +186,6 @@ jobs:
201186

202187
test_package_installations:
203188
name: "Installation Test ${{ matrix.os }}"
204-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
205189
strategy:
206190
fail-fast: false
207191
matrix:
@@ -212,7 +196,6 @@ jobs:
212196
runs-on: ${{ matrix.os }}
213197
timeout-minutes: 45
214198
permissions:
215-
id-token: write # This is required for OIDC login (azure/login) to succeed
216199
contents: read # This is required for actions/checkout to succeed
217200
steps:
218201
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
@@ -231,15 +214,10 @@ jobs:
231214
node-version: 22
232215
bot-name: "package-installations-${{ matrix.os }}"
233216
shell: ${{ matrix.os == 'windows-latest' && 'pwsh' || 'bash' }}
234-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
235-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
236-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
237217

238218
test_clock_frozen_time_linux:
239219
name: time library - ${{ matrix.clock }}
240-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
241220
permissions:
242-
id-token: write # This is required for OIDC login (azure/login) to succeed
243221
contents: read # This is required for actions/checkout to succeed
244222
strategy:
245223
fail-fast: false
@@ -254,8 +232,5 @@ jobs:
254232
browsers-to-install: chromium
255233
command: npm run test -- --project=chromium-*
256234
bot-name: "${{ matrix.clock }}-time-library-chromium-linux"
257-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
258-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
259-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
260235
env:
261236
PW_CLOCK: ${{ matrix.clock }}

‎.github/workflows/tests_secondary.yml‎

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,12 @@ env:
1616
FORCE_COLOR: 1
1717

1818
permissions:
19-
id-token: write # This is required for OIDC login (azure/login) to succeed
2019
contents: read # This is required for actions/checkout to succeed
2120

2221
jobs:
2322
test_mac:
2423
name: ${{ matrix.os }} (${{ matrix.browser }})
2524
if: ${{ github.event_name == 'push' || github.event.label.name == 'CQ1' }}
26-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
2725
strategy:
2826
fail-fast: false
2927
matrix:
@@ -42,14 +40,10 @@ jobs:
4240
browsers-to-install: ${{ matrix.browser }} chromium
4341
command: npm run test -- --project=${{ matrix.browser }}-*
4442
bot-name: "${{ matrix.browser }}-${{ matrix.os }}"
45-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
46-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
47-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
4843

4944
test_win:
5045
name: "Windows"
5146
if: ${{ github.event_name == 'push' || github.event.label.name == 'CQ1' }}
52-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
5347
strategy:
5448
fail-fast: false
5549
matrix:
@@ -62,14 +56,10 @@ jobs:
6256
browsers-to-install: ${{ matrix.browser }} chromium
6357
command: npm run test -- --project=${{ matrix.browser }}-* ${{ matrix.browser == 'firefox' && '--workers 1' || '' }}
6458
bot-name: "${{ matrix.browser }}-windows-latest"
65-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
66-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
67-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
6859

6960
test-package-installations-other-node-versions:
7061
name: "Installation Test ${{ matrix.os }} (${{ matrix.node_version }})"
7162
if: ${{ github.event_name == 'push' || github.event.label.name == 'CQ1' }}
72-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
7363
runs-on: ${{ matrix.os }}
7464
strategy:
7565
fail-fast: false
@@ -98,13 +88,9 @@ jobs:
9888
node-version: ${{ matrix.node_version }}
9989
command: npm run itest
10090
bot-name: "package-installations-${{ matrix.os }}-node${{ matrix.node_version }}"
101-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
102-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
103-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
10491

10592
driver_linux:
10693
name: "Driver"
107-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
10894
strategy:
10995
fail-fast: false
11096
runs-on: ubuntu-22.04
@@ -115,15 +101,11 @@ jobs:
115101
browsers-to-install: chromium
116102
command: npm run ctest
117103
bot-name: "driver"
118-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
119-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
120-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
121104
env:
122105
PWTEST_MODE: driver
123106

124107
tracing_linux:
125108
name: Tracing ${{ matrix.browser }}
126-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
127109
strategy:
128110
fail-fast: false
129111
matrix:
@@ -143,15 +125,11 @@ jobs:
143125
browsers-to-install: ${{ matrix.browser }} chromium
144126
command: npm run test -- --project=${{ matrix.browser }}-*
145127
bot-name: "tracing-${{ matrix.browser }}"
146-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
147-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
148-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
149128
env:
150129
PWTEST_TRACE: 1
151130

152131
test_chromium_channels:
153132
name: Test ${{ matrix.channel }} on ${{ matrix.runs-on }}
154-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
155133
runs-on: ${{ matrix.runs-on }}
156134
strategy:
157135
fail-fast: false
@@ -176,15 +154,11 @@ jobs:
176154
browsers-to-install: ${{ matrix.channel }}
177155
command: npm run ctest
178156
bot-name: ${{ matrix.channel }}-${{ matrix.runs-on }}
179-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
180-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
181-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
182157
env:
183158
PWTEST_CHANNEL: ${{ matrix.channel }}
184159

185160
test_android:
186161
name: Android
187-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
188162
runs-on: playwright-x64-ubuntu24-64-core
189163
steps:
190164
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
@@ -209,16 +183,11 @@ jobs:
209183
browsers-to-install: android
210184
command: npm run atest
211185
bot-name: "android"
212-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
213-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
214-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
215186

216187
test_clock_frozen_time_test_runner:
217188
name: time test runner - ${{ matrix.clock }}
218-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
219189
runs-on: ubuntu-22.04
220190
permissions:
221-
id-token: write # This is required for OIDC login (azure/login) to succeed
222191
contents: read # This is required for actions/checkout to succeed
223192
strategy:
224193
fail-fast: false
@@ -231,21 +200,16 @@ jobs:
231200
node-version: 22
232201
command: npm run ttest
233202
bot-name: "${{ matrix.clock }}-time-runner-chromium-linux"
234-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
235-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
236-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
237203
env:
238204
PW_CLOCK: ${{ matrix.clock }}
239205

240206
test_electron:
241207
name: Electron - ${{ matrix.os }}
242-
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
243208
strategy:
244209
fail-fast: false
245210
matrix:
246211
os: [ubuntu-latest, macos-latest, windows-latest]
247212
permissions:
248-
id-token: write # This is required for OIDC login (azure/login) to succeed
249213
contents: read # This is required for actions/checkout to succeed
250214
runs-on: ${{ matrix.os }}
251215
steps:
@@ -269,6 +233,3 @@ jobs:
269233
setup-command: npx install-electron --no
270234
command: npm run etest
271235
bot-name: "electron-${{ matrix.os }}"
272-
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
273-
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
274-
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}

‎tests/android/playwright.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ const config: Config<ServerWorkerOptions & PlaywrightWorkerOptions & PlaywrightT
3939
retries: process.env.CI ? 1 : 0,
4040
reporter: process.env.CI ? [
4141
['dot'],
42-
['json', { outputFile: path.join(outputDir, 'report.json') }],
4342
['blob'],
4443
['../config/parquetReporter.ts'],
4544
] : 'line',

‎tests/bidi/playwright.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ const testDir = path.join(__dirname, '..');
4444
const reporters = () => {
4545
const result: ReporterDescription[] = process.env.CI ? [
4646
hasDebugOutput ? ['list'] : ['dot'],
47-
['json', { outputFile: path.join(outputDir, 'report.json') }],
4847
['blob'],
4948
['../config/parquetReporter.ts'],
5049
['./csvReporter', { outputFile: path.join(outputDir, 'report.csv') }],

0 commit comments

Comments
 (0)