Skip to content

Commit befa08a

Browse files
authored
chore: remove unused potentiallyClosesScope metainfo flag (#41345)
1 parent 3c15446 commit befa08a

12 files changed

Lines changed: 15 additions & 34 deletions

File tree

‎packages/isomorphic/protocolMetainfo.ts‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
// This file is generated by generate_channels.js, do not edit manually.
1818

19-
export type MethodMetainfo = { internal?: boolean, title?: string, slowMo?: boolean, snapshot?: boolean, pause?: boolean, isAutoWaiting?: boolean, input?: boolean, potentiallyClosesScope?: boolean, group?: string };
19+
export type MethodMetainfo = { internal?: boolean, title?: string, slowMo?: boolean, snapshot?: boolean, pause?: boolean, isAutoWaiting?: boolean, input?: boolean, group?: string };
2020

2121
export const methodMetainfo = new Map<string, MethodMetainfo>([
2222
['Android.devices', { internal: true, }],
@@ -51,22 +51,22 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
5151
['APIRequestContext.fetchLog', { internal: true, }],
5252
['APIRequestContext.storageState', { title: 'Get storage state', group: 'configuration', }],
5353
['APIRequestContext.disposeAPIResponse', { internal: true, }],
54-
['APIRequestContext.dispose', { internal: true, potentiallyClosesScope: true, }],
54+
['APIRequestContext.dispose', { internal: true, }],
5555
['Artifact.pathAfterFinished', { internal: true, }],
5656
['Artifact.saveAs', { internal: true, }],
5757
['Artifact.saveAsStream', { internal: true, }],
5858
['Artifact.failure', { internal: true, }],
5959
['Artifact.stream', { internal: true, }],
6060
['Artifact.cancel', { internal: true, }],
61-
['Artifact.delete', { internal: true, potentiallyClosesScope: true, }],
61+
['Artifact.delete', { internal: true, }],
6262
['Stream.read', { internal: true, }],
6363
['Stream.close', { internal: true, }],
6464
['WritableStream.write', { internal: true, }],
6565
['WritableStream.close', { internal: true, }],
6666
['Browser.startServer', { title: 'Start server', }],
6767
['Browser.stopServer', { title: 'Stop server', }],
68-
['Browser.close', { title: 'Close browser', pause: true, potentiallyClosesScope: true, }],
69-
['Browser.killForTests', { internal: true, potentiallyClosesScope: true, }],
68+
['Browser.close', { title: 'Close browser', pause: true, }],
69+
['Browser.killForTests', { internal: true, }],
7070
['Browser.defaultUserAgentForTest', { internal: true, }],
7171
['Browser.newContext', { title: 'Create context', }],
7272
['Browser.newContextForReuse', { internal: true, }],
@@ -78,7 +78,7 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
7878
['BrowserContext.addInitScript', { title: 'Add init script', group: 'configuration', }],
7979
['BrowserContext.clearCookies', { title: 'Clear cookies', group: 'configuration', }],
8080
['BrowserContext.clearPermissions', { title: 'Clear permissions', group: 'configuration', }],
81-
['BrowserContext.close', { title: 'Close context', pause: true, potentiallyClosesScope: true, }],
81+
['BrowserContext.close', { title: 'Close context', pause: true, }],
8282
['BrowserContext.cookies', { title: 'Get cookies', group: 'getter', }],
8383
['BrowserContext.exposeBinding', { title: 'Expose binding', group: 'configuration', }],
8484
['BrowserContext.grantPermissions', { title: 'Grant permissions', group: 'configuration', }],
@@ -115,7 +115,7 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
115115
['BrowserType.launchPersistentContext', { title: 'Launch persistent context', }],
116116
['BrowserType.connectOverCDP', { title: 'Connect over CDP', }],
117117
['BrowserType.connectToWorker', { title: 'Connect to worker', }],
118-
['Disposable.dispose', { internal: true, potentiallyClosesScope: true, }],
118+
['Disposable.dispose', { internal: true, }],
119119
['Electron.launch', { title: 'Launch electron', }],
120120
['ElectronApplication.browserWindow', { internal: true, }],
121121
['ElectronApplication.evaluateExpression', { title: 'Evaluate', }],
@@ -128,7 +128,7 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
128128
['Frame.ariaSnapshot', { title: 'Aria snapshot', group: 'getter', }],
129129
['Frame.blur', { title: 'Blur', slowMo: true, snapshot: true, pause: true, }],
130130
['Frame.check', { title: 'Check', slowMo: true, snapshot: true, pause: true, input: true, isAutoWaiting: true, }],
131-
['Frame.click', { title: 'Click', slowMo: true, snapshot: true, pause: true, input: true, isAutoWaiting: true, potentiallyClosesScope: true, }],
131+
['Frame.click', { title: 'Click', slowMo: true, snapshot: true, pause: true, input: true, isAutoWaiting: true, }],
132132
['Frame.content', { title: 'Get content', snapshot: true, pause: true, }],
133133
['Frame.dragAndDrop', { title: 'Drag and drop', slowMo: true, snapshot: true, pause: true, input: true, isAutoWaiting: true, }],
134134
['Frame.drop', { title: 'Drop files or data onto an element', slowMo: true, snapshot: true, pause: true, input: true, isAutoWaiting: true, }],
@@ -170,8 +170,8 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
170170
['Frame.waitForFunction', { title: 'Wait for function', snapshot: true, pause: true, }],
171171
['Frame.waitForSelector', { title: 'Wait for selector', snapshot: true, }],
172172
['Frame.expect', { title: 'Expect "{expression}"', snapshot: true, pause: true, }],
173-
['JSHandle.dispose', { internal: true, potentiallyClosesScope: true, }],
174-
['ElementHandle.dispose', { internal: true, potentiallyClosesScope: true, }],
173+
['JSHandle.dispose', { internal: true, }],
174+
['ElementHandle.dispose', { internal: true, }],
175175
['JSHandle.evaluateExpression', { title: 'Evaluate', snapshot: true, pause: true, }],
176176
['ElementHandle.evaluateExpression', { title: 'Evaluate', snapshot: true, pause: true, }],
177177
['JSHandle.evaluateExpressionHandle', { title: 'Evaluate', snapshot: true, pause: true, }],
@@ -247,7 +247,7 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
247247
['Response.httpVersion', { internal: true, }],
248248
['Response.sizes', { internal: true, }],
249249
['Page.addInitScript', { title: 'Add init script', group: 'configuration', }],
250-
['Page.close', { title: 'Close page', pause: true, potentiallyClosesScope: true, }],
250+
['Page.close', { title: 'Close page', pause: true, }],
251251
['Page.runBeforeUnload', { title: 'Run beforeunload', pause: true, }],
252252
['Page.clearConsoleMessages', { title: 'Clear console messages', }],
253253
['Page.consoleMessages', { title: 'Get console messages', group: 'getter', }],
@@ -321,7 +321,7 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
321321
['JsonPipe.send', { internal: true, }],
322322
['JsonPipe.close', { internal: true, }],
323323
['CDPSession.send', { title: 'Send CDP command', group: 'configuration', }],
324-
['CDPSession.detach', { title: 'Detach CDP session', potentiallyClosesScope: true, group: 'configuration', }],
324+
['CDPSession.detach', { title: 'Detach CDP session', group: 'configuration', }],
325325
['BindingCall.reject', { internal: true, }],
326326
['BindingCall.resolve', { internal: true, }],
327327
['Debugger.requestPause', { title: 'Pause on next call', group: 'configuration', }],
@@ -338,7 +338,7 @@ export const methodMetainfo = new Map<string, MethodMetainfo>([
338338
['Tracing.tracingStop', { title: 'Stop tracing', group: 'configuration', }],
339339
['Tracing.harStart', { internal: true, }],
340340
['Tracing.harExport', { internal: true, }],
341-
['Worker.disconnect', { title: 'Disconnect from worker', potentiallyClosesScope: true, }],
341+
['Worker.disconnect', { title: 'Disconnect from worker', }],
342342
['Worker.evaluateExpression', { title: 'Evaluate', }],
343343
['Worker.evaluateExpressionHandle', { title: 'Evaluate', }],
344344
['Worker.updateSubscription', { internal: true, }]

‎packages/protocol/spec/api.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ APIRequestContext:
8787
internal: true
8888
parameters:
8989
reason: string?
90-
flags:
91-
potentiallyClosesScope: true
9290

9391
APIResponse:
9492
type: object

‎packages/protocol/spec/artifact.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ Artifact:
5252

5353
delete:
5454
internal: true
55-
flags:
56-
potentiallyClosesScope: true
5755

5856
Stream:
5957
type: interface

‎packages/protocol/spec/browser.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,9 @@ Browser:
4747
reason: string?
4848
flags:
4949
pause: true
50-
potentiallyClosesScope: true
5150

5251
killForTests:
5352
internal: true
54-
flags:
55-
potentiallyClosesScope: true
5653

5754
defaultUserAgentForTest:
5855
internal: true

‎packages/protocol/spec/browserContext.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ BrowserContext:
6666
reason: string?
6767
flags:
6868
pause: true
69-
potentiallyClosesScope: true
7069

7170
cookies:
7271
title: Get cookies

‎packages/protocol/spec/core.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ Disposable:
4949

5050
dispose:
5151
internal: true
52-
flags:
53-
potentiallyClosesScope: true
5452

5553
WaitInfo:
5654
type: object

‎packages/protocol/spec/frame.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ Frame:
155155
pause: true
156156
input: true
157157
isAutoWaiting: true
158-
potentiallyClosesScope: true
159158

160159
content:
161160
title: Get content

‎packages/protocol/spec/handles.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ JSHandle:
2222

2323
dispose:
2424
internal: true
25-
flags:
26-
potentiallyClosesScope: true
2725

2826
evaluateExpression:
2927
title: Evaluate

‎packages/protocol/spec/page.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ Page:
4242
reason: string?
4343
flags:
4444
pause: true
45-
potentiallyClosesScope: true
4645

4746
runBeforeUnload:
4847
title: Run beforeunload

‎packages/protocol/spec/playwright.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,8 +396,6 @@ CDPSession:
396396
detach:
397397
title: Detach CDP session
398398
group: configuration
399-
flags:
400-
potentiallyClosesScope: true
401399

402400
events:
403401

0 commit comments

Comments
 (0)