Add telemetry events for desktop opening actions (#1315)

Add telemetry events for desktop opening actions and feature flag handling

Co-authored-by: Amit Joshi <[email protected]>

Author: amitjoshi438

src/common/OneDSLoggerTelemetry/web/client/webExtensionTelemetryEvents.ts

@@ -129,7 +129,12 @@ export enum webExtensionTelemetryEventNames {
     WEB_EXTENSION_SEARCH_TEXT = "WebExtensionSearchText",
     WEB_EXTENSION_SEARCH_FILE = "WebExtensionSearchFile",
     WEB_EXTENSION_SOURCE_ATTRIBUTE_INVALID = "WebExtensionSourceAttributeInvalid",
+    WEB_EXTENSION_OPEN_DESKTOP_CLICKED = "WebExtensionOpenDesktopClicked",
+    WEB_EXTENSION_OPEN_DESKTOP_FEATURE_DISABLED = "WebExtensionOpenDesktopFeatureDisabled",
     WEB_EXTENSION_OPEN_DESKTOP_TRIGGERED = "WebExtensionOpenDesktopTriggered",
     WEB_EXTENSION_OPEN_DESKTOP_FAILED = "WebExtensionOpenDesktopFailed",
+    WEB_EXTENSION_OPEN_DESKTOP_URI_OPENED = "WebExtensionOpenDesktopUriOpened",
+    WEB_EXTENSION_OPEN_DESKTOP_DIALOG_DOWNLOAD_CLICKED = "WebExtensionOpenDesktopDialogDownloadClicked",
+    WEB_EXTENSION_OPEN_DESKTOP_DIALOG_UPDATE_CLICKED = "WebExtensionOpenDesktopDialogUpdateClicked",
     WEB_EXTENSION_DUPLICATE_FOLDER_NAME_CREATED = "WebExtensionDuplicateFolderNameCreated"
 }

src/web/client/webViews/powerPagesNavigationProvider.ts

@@ -173,10 +173,31 @@ export class PowerPagesNavigationProvider implements vscode.TreeDataProvider<Pow
     }
 
     openInDesktop(): void {
+        WebExtensionContext.telemetry.sendInfoTelemetry(
+            webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_CLICKED,
+            {
+                hasECSFeatureGate: 'true'
+            }
+        );
+
         try {
             const websiteId = WebExtensionContext.urlParametersMap?.get(PowerPagesNavigationConstants.urlParams.WEBSITE_ID);
             const envId = WebExtensionContext.urlParametersMap?.get(PowerPagesNavigationConstants.urlParams.ENV_ID);
 
+            // Check if open in desktop is enabled via ECS flag
+            const isOpenInDesktopEnabled = ECSFeaturesClient.getConfig(EnableOpenInDesktop).enableOpenInDesktop;
+
+            // Track ECS feature flag status
+            if (!isOpenInDesktopEnabled) {
+                WebExtensionContext.telemetry.sendInfoTelemetry(
+                    webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_FEATURE_DISABLED,
+                    {
+                        reason: 'ecs_feature_flag_disabled'
+                    }
+                );
+                return;
+            }
+
             // Validate required parameters
             if (!websiteId) {
                 vscode.window.showErrorMessage(vscode.l10n.t(PowerPagesNavigationConstants.messages.WEBSITE_ID_NOT_AVAILABLE));
@@ -213,18 +234,54 @@ export class PowerPagesNavigationProvider implements vscode.TreeDataProvider<Pow
                     return;
                 }
 
+                // Track desktop flow trigger (before attempting to open)
+                WebExtensionContext.telemetry.sendInfoTelemetry(
+                    webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_TRIGGERED,
+                    {
+                        websiteId: websiteId,
+                        environmentId: environmentId,
+                        desktopUri: desktopUri
+                    }
+                );
+
                 // Open in VS Code Desktop
                 vscode.env.openExternal(vscode.Uri.parse(desktopUri));
 
+                // Track successful URI opening
+                WebExtensionContext.telemetry.sendInfoTelemetry(
+                    webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_URI_OPENED,
+                    {
+                        websiteId: websiteId,
+                        environmentId: environmentId,
+                        uriGenerated: PowerPagesNavigationConstants.values.TRUE,
+                    }
+                );
+
                 // Show informational message with fallback options (don't await to avoid blocking)
                 vscode.window.showInformationMessage(
                     vscode.l10n.t(PowerPagesNavigationConstants.messages.OPENING_IN_VS_CODE_DESKTOP),
                     vscode.l10n.t(PowerPagesNavigationConstants.messages.DOWNLOAD_VS_CODE),
                     vscode.l10n.t(PowerPagesNavigationConstants.messages.UPDATE_EXTENSION),
-                ).then((showInstructions) => {
-                    if (showInstructions === vscode.l10n.t(PowerPagesNavigationConstants.messages.DOWNLOAD_VS_CODE)) {
+                ).then((selectedOption) => {
+                    if (selectedOption === vscode.l10n.t(PowerPagesNavigationConstants.messages.DOWNLOAD_VS_CODE)) {
+                        WebExtensionContext.telemetry.sendInfoTelemetry(
+                            webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_DIALOG_DOWNLOAD_CLICKED,
+                            {
+                                websiteId: websiteId,
+                                environmentId: environmentId,
+                                action: 'download_vscode_clicked'
+                            }
+                        );
                         vscode.env.openExternal(vscode.Uri.parse(PowerPagesNavigationConstants.urls.VS_CODE_DOWNLOAD));
-                    } else if (showInstructions === vscode.l10n.t(PowerPagesNavigationConstants.messages.UPDATE_EXTENSION)) {
+                    } else if (selectedOption === vscode.l10n.t(PowerPagesNavigationConstants.messages.UPDATE_EXTENSION)) {
+                        WebExtensionContext.telemetry.sendInfoTelemetry(
+                            webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_DIALOG_UPDATE_CLICKED,
+                            {
+                                websiteId: websiteId,
+                                environmentId: environmentId,
+                                action: 'update_extension_clicked'
+                            }
+                        );
                         vscode.env.openExternal(vscode.Uri.parse(PowerPagesNavigationConstants.urls.VS_CODE_MARKETPLACE));
                     }
                 });
@@ -290,19 +347,6 @@ export class PowerPagesNavigationProvider implements vscode.TreeDataProvider<Pow
 
             const finalUri = `${baseUri}?${params.toString()}`;
 
-            // Log telemetry for successful URI generation
-            WebExtensionContext.telemetry.sendInfoTelemetry(
-                webExtensionTelemetryEventNames.WEB_EXTENSION_OPEN_DESKTOP_TRIGGERED,
-                {
-                    websiteId: websiteId,
-                    environmentId: environmentId,
-                    desktopUri: finalUri,
-                    hasSiteName: siteName ? PowerPagesNavigationConstants.values.TRUE : PowerPagesNavigationConstants.values.FALSE,
-                    hasSiteUrl: params.has(PowerPagesNavigationConstants.urlParams.SITE_URL) ? PowerPagesNavigationConstants.values.TRUE : PowerPagesNavigationConstants.values.FALSE,
-                    schema: schema
-                }
-            );
-
             return finalUri;
 
         } catch (error) {