From 3f8b7f4247c17fd8ddf2f545691bd5de1c99b9e2 Mon Sep 17 00:00:00 2001 From: Ying Chen Date: Thu, 14 Sep 2023 17:20:52 +0800 Subject: [PATCH] [BUG][Promptflow SDK& CLI] docker build build is confusing (#379) # Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes]** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. --------- Co-authored-by: Ying Chen <2601502859@qq.com> --- docs/cloud/azureai/deploy-to-azure-appservice.md | 4 ++-- docs/how-to-guides/deploy-a-flow/deploy-using-docker.md | 4 ++-- examples/tutorials/e2e-development/chat-with-pdf.md | 4 ++-- examples/tutorials/flow-deploy/azure-app-service/README.md | 4 ++-- examples/tutorials/flow-deploy/docker/README.md | 4 ++-- examples/tutorials/flow-deploy/kubernetes/README.md | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/cloud/azureai/deploy-to-azure-appservice.md b/docs/cloud/azureai/deploy-to-azure-appservice.md index 03504f2b663..13b245d0e72 100644 --- a/docs/cloud/azureai/deploy-to-azure-appservice.md +++ b/docs/cloud/azureai/deploy-to-azure-appservice.md @@ -10,7 +10,7 @@ This example demos how to deploy [web-classification](https://github.com/microso Use the command below to build a flow as docker format app: ```bash -pf flow build --source ../../flows/standard/web-classification --output build --format docker +pf flow build --source ../../flows/standard/web-classification --output dist --format docker ``` Note that all dependent connections must be created before building as docker. @@ -27,7 +27,7 @@ The two scripts will do the following things: :::{tab-item} Bash Example command to use bash script: ```shell -bash deploy.sh --path build -i --name my_app_23d8m -r -g +bash deploy.sh --path dist -i --name my_app_23d8m -r -g ``` See the full parameters by `bash deploy.sh -h`. ::: diff --git a/docs/how-to-guides/deploy-a-flow/deploy-using-docker.md b/docs/how-to-guides/deploy-a-flow/deploy-using-docker.md index 164496b0576..872676b66b6 100644 --- a/docs/how-to-guides/deploy-a-flow/deploy-using-docker.md +++ b/docs/how-to-guides/deploy-a-flow/deploy-using-docker.md @@ -53,7 +53,7 @@ refer to [Setup connection for web-classifiction](https://github.com/microsoft/p Use the command below to build a flow as docker format app: ```bash -pf flow build --source ../../flows/standard/web-classification --output build --format docker +pf flow build --source ../../flows/standard/web-classification --output dist --format docker ``` Note that all dependent connections must be created before exporting as docker. @@ -65,7 +65,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image Run the command below to build image: ```bash -docker build build -t web-classification-serve +docker build dist -t web-classification-serve ``` ### Run Docker image diff --git a/examples/tutorials/e2e-development/chat-with-pdf.md b/examples/tutorials/e2e-development/chat-with-pdf.md index f7e846fbc70..84336aa3a62 100644 --- a/examples/tutorials/e2e-development/chat-with-pdf.md +++ b/examples/tutorials/e2e-development/chat-with-pdf.md @@ -310,7 +310,7 @@ the other choices, please refer to [flow deploy docs](https://microsoft.github.i Use the command below to build a flow as docker format app: ```bash -pf flow build --source . --output build --format docker +pf flow build --source . --output dist --format docker ``` ### Deploy with Docker @@ -321,7 +321,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image Run the command below to build image: ```shell -docker build build -t chat-with-pdf-serve +docker build dist -t chat-with-pdf-serve ``` #### Run Docker image diff --git a/examples/tutorials/flow-deploy/azure-app-service/README.md b/examples/tutorials/flow-deploy/azure-app-service/README.md index 6501b9387cc..b11e243e23f 100644 --- a/examples/tutorials/flow-deploy/azure-app-service/README.md +++ b/examples/tutorials/flow-deploy/azure-app-service/README.md @@ -18,7 +18,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key= Use the command below to build a flow as docker format app: ```bash -pf flow build --source ../../../flows/standard/web-classification --output build --format docker +pf flow build --source ../../../flows/standard/web-classification --output dist --format docker ``` @@ -32,7 +32,7 @@ The two scripts will do the following things: Example command to use bash script: ```shell -bash deploy.sh --path build -i --name my_app_23d8m -r -g +bash deploy.sh --path dist -i --name my_app_23d8m -r -g ``` Example command to use powershell script: diff --git a/examples/tutorials/flow-deploy/docker/README.md b/examples/tutorials/flow-deploy/docker/README.md index 9cd65376a79..fc1d36c8d83 100644 --- a/examples/tutorials/flow-deploy/docker/README.md +++ b/examples/tutorials/flow-deploy/docker/README.md @@ -14,7 +14,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key= Use the command below to build a flow as docker format app: ```bash -pf flow build --source ../../../flows/standard/web-classification --output build --format docker +pf flow build --source ../../../flows/standard/web-classification --output dist --format docker ``` ## Deploy with Docker @@ -25,7 +25,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image Run the command below to build image: ```shell -docker build build -t web-classification-serve +docker build dist -t web-classification-serve ``` ### Run Docker image diff --git a/examples/tutorials/flow-deploy/kubernetes/README.md b/examples/tutorials/flow-deploy/kubernetes/README.md index dbf72c68bff..9be5f5b673d 100644 --- a/examples/tutorials/flow-deploy/kubernetes/README.md +++ b/examples/tutorials/flow-deploy/kubernetes/README.md @@ -15,7 +15,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key= Use the command below to build a flow as docker format app: ```bash -pf flow build --source ../../../flows/standard/web-classification --output build --format docker +pf flow build --source ../../../flows/standard/web-classification --output dist --format docker ``` ## Deploy with Kubernetes @@ -26,7 +26,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image Then run the command below: ```shell -cd build +cd dist docker build . -t web-classification-serve ```