You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Focus is moved to the first dialog. Tabbing moves focus to the only focusable element in this dialog which is a back button (as an odd side-effect, if you hit tab, and then enter, both dialogs close). As a result, the second dialog, which is the one actually shown to the user, is not navigable by keyboard and no focus-visible indicators are shown. This also impacts screen reader accessibility.
To Reproduce
Steps to reproduce the behavior:
Go to settings and open "Version History"
Hit the tab key (once or many times) and see no focus-visible indicators
You are unable to interact with the UI via keyboard navigation in any meaningful way
Hit "Enter" after hitting the tab key to see the dialogs close. This is because the back button in the first dialog is focussed at this point, but this is not clear to the user.
Expected behavior
Only one dialog should be rendered and take focus.
Screenshots
Screenshot of DOM showing dialogs 1 and 2 as siblings:
micro:bit version (please complete the following information):
Not hardware related
Desktop (please complete the following information):
Windows 11
Browser Chrome v132
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Describe the bug
When triggering "Version History" feature either by mouse or keyboard, two dialogs are rendered.
See this code in dialogs.tsx where
core.dialogAsync
results in the first dialog being rendered whereoptions.jsx
are rendered inside this dialog as a child component. However, in this case, options.jsx is the TimeMachine component which is a dialog in its own right and is rendered as a portal outside and as a sibling to the first dialog.Focus is moved to the first dialog. Tabbing moves focus to the only focusable element in this dialog which is a back button (as an odd side-effect, if you hit tab, and then enter, both dialogs close). As a result, the second dialog, which is the one actually shown to the user, is not navigable by keyboard and no focus-visible indicators are shown. This also impacts screen reader accessibility.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Only one dialog should be rendered and take focus.
Screenshots
![Image](https://private-user-images.githubusercontent.com/95928279/408630699-c7fa6ac2-e734-4fa7-98ba-02b07acf3ee6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTcyMTAsIm5iZiI6MTczODg1NjkxMCwicGF0aCI6Ii85NTkyODI3OS80MDg2MzA2OTktYzdmYTZhYzItZTczNC00ZmE3LTk4YmEtMDJiMDdhY2YzZWU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE1NDgzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5Y2RmNjU1NWJhZTM4OTc3N2I0N2EzZThlMjUxMGUwODI2NTkyNzU3ZDdkYjAwMDM0YmMyN2M5ZjYyMWZhNzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zvnm7xoWw23yZ0zz6UOTxELBEFTec7INvbnPiZ2gBuQ)
Screenshot of DOM showing dialogs 1 and 2 as siblings:
micro:bit version (please complete the following information):
Not hardware related
Desktop (please complete the following information):
Additional context
N/A
The text was updated successfully, but these errors were encountered: