ADO: Change full checkout persistCredentials default back to false
#10553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
changed the title
persistCredentials default to falsepersistCredentials default back to false
jonthysell
added
security
A change in beachball behavior means we need to make sure we have (the right) credentials ready to run beachball commands in our various ADO pipelines. I made some temporary workarounds to unblock pipelines: - [Add persistCredentials: true to checkout](microsoft@ba5b008) - [Update publish.yml to not set credentials until after running credscan](microsoft@19ef068) - [Parameterize persistCredentials, default to true](microsoft@462407c) - [Update publish.yml to not persist credentials](microsoft@8f60783) This PR updates our pipelines to use the most appropriate credentials for the tasks they need to run. - Bug fix (non-breaking change which fixes an issue) The temporary workarounds made **all** "full checkouts" in ADO persist the credentials used to checkout the repo, but that will override using any other credentials later in the pipeline. In the case of publish, we actually need rnbot's admin credentials, so the publish pipeline reverts to the previous behavior of no longer persisting creds at checkout and instead configuring for rnbot's creds. However, many other tasks do trivial/temporary local repo operations using rnbot's credentials. This is an unnecessary (and potentially risky) elevation that we shouldn't do anymore. This PR sets "full checkouts" back to not persisting credentials by default, because most tasks don't need them. Then, in the places where we do need credentials for later git/beachball commands, we choose from this prioritized list: 1. If possible, set `persistCredentials` to `true`, and use the (less-powerful) credentials 2. Otherwise, and only if the tasks require it, continue using rnbot's credentials N/A If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
jonthysell
force-pushed
the
creddefault
branch
from
3ff0bef
to
3594cd3
Compare
jonthysell
added
the
AutoMerge
|
Hello @jonthysell! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 8 hours 22 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
The beachball issue that precipitated these changes: microsoft/beachball#674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A change in beachball behavior means we need to make sure we have (the right) credentials ready to run beachball commands in our various ADO pipelines.
I made some temporary workarounds to unblock pipelines:
This PR updates our pipelines to use the most appropriate credentials for the tasks they need to run.
Type of Change
Why
The temporary workarounds made all "full checkouts" in ADO persist the credentials used to checkout the repo, but that will override using any other credentials later in the pipeline.
In the case of publish, we actually need rnbot's admin credentials, so the publish pipeline reverts to the previous behavior of no longer persisting creds at checkout and instead configuring for rnbot's creds.
However, many other tasks do trivial/temporary local repo operations using rnbot's credentials. This is an unnecessary (and potentially risky) elevation that we shouldn't do anymore.
What
This PR sets "full checkouts" back to not persisting credentials by default, because most tasks don't need them. Then, in the places where we do need credentials for later git/beachball commands, we choose from this prioritized list:
persistCredentialstotrue, and use the (less-powerful) credentialsMicrosoft Reviewers: Open in CodeFlow