fixup! Update tests to use StringBufferTerminalProvider.getAllOutputAsChunks.

iclanton · iclanton · commit 3dce7afa173b · 2026-01-03T19:28:08.000-08:00
diff --git a/libraries/heft-config-file/src/test/ConfigurationFile.test.ts b/libraries/heft-config-file/src/test/ConfigurationFile.test.ts
@@ -26,7 +26,7 @@ describe('ConfigurationFile', () => {
   });
 
   afterEach(() => {
-    expect(terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })).toMatchSnapshot();
+    expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
   });
 
   describe('A simple config file', () => {
diff --git a/libraries/localization-utilities/src/parsers/test/parseResx.test.ts b/libraries/localization-utilities/src/parsers/test/parseResx.test.ts
@@ -16,9 +16,7 @@ describe(parseResx.name, () => {
   });
 
   afterEach(() => {
-    expect(terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })).toMatchSnapshot(
-      'terminal output'
-    );
+    expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot('terminal output');
   });
 
   async function testResxAsync(
diff --git a/libraries/operation-graph/src/test/OperationExecutionManager.test.ts b/libraries/operation-graph/src/test/OperationExecutionManager.test.ts
@@ -68,9 +68,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result).toBe(OperationStatus.NoOp);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
       });
 
       it('handles trivial input', async () => {
@@ -89,9 +87,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result).toBe(OperationStatus.Success);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
 
         expect(operation.state?.status).toBe(OperationStatus.NoOp);
       });
@@ -139,9 +135,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result).toBe(OperationStatus.Success);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
 
         expect(runAlpha).toHaveBeenCalledTimes(1);
         expect(runBeta).toHaveBeenCalledTimes(1);
@@ -193,9 +187,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result).toBe(OperationStatus.Failure);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
         expect(runAlpha).toHaveBeenCalledTimes(1);
         expect(runBeta).toHaveBeenCalledTimes(0);
 
@@ -226,9 +218,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result).toBe(OperationStatus.NoOp);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
       });
 
       it('respects priority order', async () => {
@@ -281,9 +271,7 @@ describe(OperationExecutionManager.name, () => {
         expect(executed).toEqual([beta, alpha]);
 
         expect(result).toBe(OperationStatus.Success);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
 
         expect(runAlpha).toHaveBeenCalledTimes(1);
         expect(runBeta).toHaveBeenCalledTimes(1);
@@ -336,9 +324,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result).toBe(OperationStatus.Success);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
 
         expect(run).toHaveBeenCalledTimes(2);
 
@@ -405,9 +391,7 @@ describe(OperationExecutionManager.name, () => {
         expect(betaRequestRun).toBeDefined();
 
         expect(result1).toBe(OperationStatus.Success);
-        expect(
-          terminalProvider1.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot('first');
+        expect(terminalProvider1.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot('first');
 
         expect(runAlpha).toHaveBeenCalledTimes(1);
         expect(runBeta).toHaveBeenCalledTimes(1);
@@ -439,9 +423,7 @@ describe(OperationExecutionManager.name, () => {
         });
 
         expect(result2).toBe(OperationStatus.Success);
-        expect(
-          terminalProvider2.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot('second');
+        expect(terminalProvider2.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot('second');
 
         expect(runAlpha).toHaveBeenCalledTimes(2);
         expect(runBeta).toHaveBeenCalledTimes(2);
diff --git a/libraries/rush-lib/src/api/test/CustomTipsConfiguration.test.ts b/libraries/rush-lib/src/api/test/CustomTipsConfiguration.test.ts
@@ -58,10 +58,7 @@ describe(CustomTipsConfiguration.name, () => {
       afterEach(() => {
         jest.restoreAllMocks();
 
-        const terminalProviderOutput: IOutputChunk<TerminalProviderSeverityName>[] =
-          terminalProvider.getAllOutputAsChunks({
-            severityAsNames: true
-          });
+        const terminalProviderOutput: IOutputChunk[] = terminalProvider.getAllOutputAsChunks();
         const lineSplitTerminalProviderOutput: string[] = [];
         for (const { text, severity } of terminalProviderOutput) {
           const lines: string[] = text.split('[n]');
diff --git a/libraries/rush-lib/src/api/test/RushProjectConfiguration.test.ts b/libraries/rush-lib/src/api/test/RushProjectConfiguration.test.ts
@@ -63,9 +63,7 @@ function validateConfiguration(rushProjectConfiguration: RushProjectConfiguratio
         terminal
       );
     } finally {
-      expect(
-        terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-      ).toMatchSnapshot();
+      expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
     }
   }
 }
@@ -92,9 +90,7 @@ function validateConfigurationWithParameters(
         terminal
       );
     } finally {
-      expect(
-        terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-      ).toMatchSnapshot();
+      expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
     }
   }
 }
diff --git a/libraries/rush-lib/src/logic/operations/test/BuildPlanPlugin.test.ts b/libraries/rush-lib/src/logic/operations/test/BuildPlanPlugin.test.ts
@@ -141,8 +141,7 @@ describe(BuildPlanPlugin.name, () => {
       expect(
         stringBufferTerminalProvider.getAllOutputAsChunks({
           normalizeSpecialCharacters: false,
-          asFlat: true,
-          severityAsNames: true
+          asFlat: true
         })
       ).toMatchSnapshot();
     });
diff --git a/libraries/rush-lib/src/logic/operations/test/OperationMetadataManager.test.ts b/libraries/rush-lib/src/logic/operations/test/OperationMetadataManager.test.ts
@@ -63,9 +63,7 @@ describe(OperationMetadataManager.name, () => {
       errorLogPath: '/path/to/errorLog'
     });
 
-    expect(
-      mockTerminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-    ).toMatchSnapshot();
+    expect(mockTerminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
     expect(mockTerminalProvider.getWarningOutput()).toBeFalsy();
   });
 
@@ -89,9 +87,7 @@ describe(OperationMetadataManager.name, () => {
       errorLogPath: '/path/to/errorLog'
     });
 
-    expect(
-      mockTerminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-    ).toMatchSnapshot();
+    expect(mockTerminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
   });
 
   it('should restore mixed chunked output', async () => {
@@ -113,9 +109,7 @@ describe(OperationMetadataManager.name, () => {
       terminalProvider: mockTerminalProvider,
       errorLogPath: '/path/to/errorLog'
     });
-    expect(
-      mockTerminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-    ).toMatchSnapshot();
+    expect(mockTerminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
   });
 
   it("should fallback to the log file when chunked output isn't available", async () => {
diff --git a/libraries/rush-lib/src/logic/pnpm/test/PnpmShrinkwrapFile.test.ts b/libraries/rush-lib/src/logic/pnpm/test/PnpmShrinkwrapFile.test.ts
@@ -546,9 +546,7 @@ snapshots:
             terminal
           )
         ).toThrowError(AlreadyReportedError);
-        expect(
-          terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })
-        ).toMatchSnapshot();
+        expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();
       });
     });
   });
diff --git a/libraries/rush-lib/src/logic/test/InstallHelpers.test.ts b/libraries/rush-lib/src/logic/test/InstallHelpers.test.ts
@@ -28,8 +28,7 @@ describe('InstallHelpers', () => {
       expect(
         terminalProvider.getAllOutputAsChunks({
           normalizeSpecialCharacters: true,
-          asFlat: true,
-          severityAsNames: true
+          asFlat: true
         })
       ).toMatchSnapshot('Terminal Output');
       mockJsonFileSave.mockClear();
diff --git a/libraries/rush-lib/src/logic/test/ProjectImpactGraphGenerator.test.ts b/libraries/rush-lib/src/logic/test/ProjectImpactGraphGenerator.test.ts
@@ -25,8 +25,7 @@ async function runTestForExampleRepoAsync(
   expect(
     terminalProvider.getAllOutputAsChunks({
       normalizeSpecialCharacters: true,
-      asFlat: true,
-      severityAsNames: true
+      asFlat: true
     })
   ).toMatchSnapshot('Terminal Output');
 }
diff --git a/libraries/terminal/src/test/PrefixProxyTerminalProvider.test.ts b/libraries/terminal/src/test/PrefixProxyTerminalProvider.test.ts
@@ -14,9 +14,7 @@ function runTestsForTerminalProvider(
 
   function verifyProvider(): void {
     expect(baseProvider.getAllOutput(true)).toMatchSnapshot('output');
-    expect(baseProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })).toMatchSnapshot(
-      'output as chunks'
-    );
+    expect(baseProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot('output as chunks');
   }
 
   beforeEach(() => {
diff --git a/libraries/terminal/src/test/TerminalStreamWritable.test.ts b/libraries/terminal/src/test/TerminalStreamWritable.test.ts
@@ -12,7 +12,7 @@ let provider: StringBufferTerminalProvider;
 
 function verifyProvider(): void {
   expect(provider.getAllOutput()).toMatchSnapshot('output');
-  expect(provider.getAllOutputAsChunks({ severityAsNames: true })).toMatchSnapshot('output as chunks');
+  expect(provider.getAllOutputAsChunks()).toMatchSnapshot('output as chunks');
 }
 
 async function writeAsync(writable: Writable, data: string): Promise<void> {
diff --git a/libraries/terminal/src/test/__snapshots__/Terminal.test.ts.snap b/libraries/terminal/src/test/__snapshots__/Terminal.test.ts.snap
diff --git a/rush-plugins/rush-http-build-cache-plugin/src/test/HttpBuildCacheProvider.test.ts b/rush-plugins/rush-http-build-cache-plugin/src/test/HttpBuildCacheProvider.test.ts

Original file line number	Diff line number	Diff line change
`@@ -63,9 +63,7 @@ function validateConfiguration(rushProjectConfiguration: RushProjectConfiguratio`
`63`	`63`	`terminal`
`64`	`64`	`);`
`65`	`65`	`} finally {`
`66`		`- expect(`
`67`		`- terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })`
`68`		`- ).toMatchSnapshot();`
	`66`	`+ expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();`
`69`	`67`	`}`
`70`	`68`	`}`
`71`	`69`	`}`
`@@ -92,9 +90,7 @@ function validateConfigurationWithParameters(`
`92`	`90`	`terminal`
`93`	`91`	`);`
`94`	`92`	`} finally {`
`95`		`- expect(`
`96`		`- terminalProvider.getAllOutputAsChunks({ asFlat: true, severityAsNames: true })`
`97`		`- ).toMatchSnapshot();`
	`93`	`+ expect(terminalProvider.getAllOutputAsChunks({ asFlat: true })).toMatchSnapshot();`
`98`	`94`	`}`
`99`	`95`	`}`
`100`	`96`	`}`