Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] punycode is deprecated in Node v22 #5008

Open
UberMouse opened this issue Nov 19, 2024 · 0 comments
Open

[rush] punycode is deprecated in Node v22 #5008

UberMouse opened this issue Nov 19, 2024 · 0 comments

Comments

@UberMouse
Copy link
Contributor

UberMouse commented Nov 19, 2024

Summary

When executing Rush under Node v22 via install-run-rush.js you get an error about punycode being deprecated printed, this is coming from the dependency on whatwg-url, newer versions of whatwg-url now depend on a userland implementation of punycode

Repro steps

  1. Be on Node v22
  2. Run rush via node common/scripts/install-run-rush.js
  3. See deprecation warning

Expected result:
No deprecation warning is printed

Actual result:
The following deprecation warning is printed

(node:149018) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
    at loadBuiltinModule (node:internal/modules/helpers:108:7)
    at Module._load (node:internal/modules/cjs/loader:1099:17)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1339:12)
    at require (node:internal/modules/helpers:135:16)
    at Object.<anonymous> (/home/taylorl/code/kawaka/common/temp/install-run/@[email protected]/node_modules/whatwg-url/lib/url-state-machine.js:2:18)

Details

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.117.9
rushVersion from rush.json? 5.140.1
useWorkspaces from rush.json? true
Operating system? Linux
Would you consider contributing a PR? No
Node.js version (node -v)? v22.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant