Skip to content

Commit

Permalink
.Net: Processes - Resolving issues with integrations test in Dapr run…
Browse files Browse the repository at this point in the history
…time. (#9646)

### Description

This PR fixes two issues our integration tests in the Dapr runtime. All
tests pass after this change is applied.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
  • Loading branch information
alliscode authored Nov 11, 2024
1 parent 7d9f834 commit 4283cf2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ private async Task<bool> IsEndMessageSentAsync()
/// <exception cref="InvalidOperationException"></exception>
private async Task<DaprProcessInfo> ToDaprProcessInfoAsync()
{
var processState = new KernelProcessState(this.Name, this._stepState!.Version, this.Id.GetId());
var processState = new KernelProcessState(this.Name, this._process!.State.Version, this.Id.GetId());
var stepTasks = this._steps.Select(step => step.ToDaprStepInfoAsync()).ToList();
var steps = await Task.WhenAll(stepTasks).ConfigureAwait(false);
return new DaprProcessInfo { InnerStepDotnetType = this._process!.InnerStepDotnetType, Edges = this._process!.Edges, State = processState, Steps = [.. steps] };
Expand Down
10 changes: 5 additions & 5 deletions dotnet/src/InternalUtilities/process/Runtime/ProcessEvent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,27 @@ public record ProcessEvent
/// <summary>
/// The namespace of the event.
/// </summary>
internal string Namespace { get; init; } = string.Empty;
public string Namespace { get; init; } = string.Empty;

/// <summary>
/// The source Id of the event.
/// </summary>
internal string SourceId { get; init; } = string.Empty;
public string SourceId { get; init; } = string.Empty;

/// <summary>
/// An optional data payload associated with the event.
/// </summary>
internal object? Data { get; init; }
public object? Data { get; init; }

/// <summary>
/// The visibility of the event.
/// </summary>
internal KernelProcessEventVisibility Visibility { get; init; }
public KernelProcessEventVisibility Visibility { get; init; }

/// <summary>
/// This event represents a runtime error / exception raised internally by the framework.
/// </summary>
internal bool IsError { get; init; }
public bool IsError { get; init; }

/// <summary>
/// The Qualified Id of the event.
Expand Down

0 comments on commit 4283cf2

Please sign in to comment.