Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Bug: Python Sequential Planner config.json execution_settings "stop_sequences" should be "stop" #6989

Open
AndreasKunar opened this issue Jun 27, 2024 · 0 comments
Labels
bug Something isn't working python Pull requests for the Python Semantic Kernel triage

Comments

@AndreasKunar
Copy link

Describe the bug
In file python/semantic_kernel/planners/sequential_planner/Plugins/SequentialPlanning/config.json, the item "stop_sequences" in "execution_settings" should be named "stop" instead, since OpenAIPromptExecutionSettings and others just define this setting as simply "stop". There is no "stop_sequences" setting in any of the Python ai service's' PromptExecutionSettings.

Additional context
Very low priority. There currently seems no execution impact from this, but it's still a bug.

@AndreasKunar AndreasKunar added the bug Something isn't working label Jun 27, 2024
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels Jun 27, 2024
@github-actions github-actions bot changed the title Bug: Python Sequential Planner config.json execution_settings "stop_sequences" should be "stop" Python: Bug: Python Sequential Planner config.json execution_settings "stop_sequences" should be "stop" Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests for the Python Semantic Kernel triage
Projects
Status: No status
Development

No branches or pull requests

2 participants