-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: fix a bug in the Makefile for checking if uv
is installed or not
#9763
Open
rewrlution
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
rewrlution:issue-9067
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Nov 19, 2024
github-actions
bot
changed the title
Check if
Python: Check if Nov 19, 2024
uv
exists or notuv
exists or not
dluc
reviewed
Nov 19, 2024
rewrlution
changed the title
Python: Check if
Python: fix a bug in the Makefile for checking the existence of Nov 20, 2024
uv
exists or notuv
rewrlution
changed the title
Python: fix a bug in the Makefile for checking the existence of
Python: fix a bug in the Makefile for checking if Nov 20, 2024
uv
uv
is installed or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required?
This is the issue: Python: Bug: Make Install does not work on clean builds #9067
A user reports that the Makefile cannot install
uv
.What problem does it solve?
What scenario does it contribute to?
With this fix, users who do not have
uv
installed in their machine will now have the Makefile to installuv
for them.If it fixes an open issue, please link to the issue here.
Python: Bug: Make Install does not work on clean builds #9067
Description
In the current Makefile, we assign the evaluation result of
$(shell uv --version 2> /dev/null)
toUV_VERSION
, which will be an empty string""
. If we useifdef UV_VERSION
to check whetheruv
is installed or not, it will always be true. Therefore, I useifneq ($(UV_VERSION),)
to check the existenceuv
.Another minor improvement that I made to the
Makefile
is that I guard the.SILENT
keyword withifndef
so that users can turn on/off theVERBOSE
mode easily. For example, they can enableVERBOSE
mode by runningmake install VERBOSE=1
. By default, it uses theSILENT
mode.Contribution Checklist