From 7da915c69995bfd8ea65018e0ce668bd4279001d Mon Sep 17 00:00:00 2001 From: huang huijing Date: Tue, 19 Nov 2024 14:56:54 -0800 Subject: [PATCH 1/3] Check if `uv` exists or not --- python/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/Makefile b/python/Makefile index 1e165a1539ba..ce3ac397fc36 100644 --- a/python/Makefile +++ b/python/Makefile @@ -37,7 +37,7 @@ install: UV_VERSION = $(shell uv --version 2> /dev/null) install-uv: # Check if uv is installed -ifdef UV_VERSION +ifeq ($(UV_VERSION),"") echo "uv found $(UV_VERSION)" echo "running uv update" uv self update From 69c3c4f6f99b57df6173bd446a7406302b56e025 Mon Sep 17 00:00:00 2001 From: huang huijing Date: Wed, 20 Nov 2024 09:52:43 -0800 Subject: [PATCH 2/3] Add ifdef for verbose mode --- python/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/python/Makefile b/python/Makefile index ce3ac397fc36..83740f14c0b4 100644 --- a/python/Makefile +++ b/python/Makefile @@ -1,7 +1,9 @@ SHELL = /bin/bash .PHONY: help install clean build +ifndef VERBOSE .SILENT: +endif all: install ifeq ($(PYTHON_VERSION),) From 6d0ddce539011ae92cea47b26063ee7e70c20b9e Mon Sep 17 00:00:00 2001 From: huang huijing Date: Wed, 20 Nov 2024 10:05:20 -0800 Subject: [PATCH 3/3] use ifneq, fix bug --- python/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/Makefile b/python/Makefile index 83740f14c0b4..e1e682583914 100644 --- a/python/Makefile +++ b/python/Makefile @@ -39,7 +39,7 @@ install: UV_VERSION = $(shell uv --version 2> /dev/null) install-uv: # Check if uv is installed -ifeq ($(UV_VERSION),"") +ifneq ($(UV_VERSION),) echo "uv found $(UV_VERSION)" echo "running uv update" uv self update