Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Store Service #2171

Merged
merged 36 commits into from
Sep 1, 2023
Merged

Query Store Service #2171

merged 36 commits into from
Sep 1, 2023

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Aug 16, 2023

Adds the Query Store service, which generates queries needed to fetch the data for all query store reports

@Benjin Benjin requested a review from kisantia August 16, 2023 00:45
@github-actions
Copy link

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@Benjin
Copy link
Contributor Author

Benjin commented Aug 16, 2023

Just a draft for now to take a look at how things are working as I finish adding the tests.

At @cheenamalhotra's recommendation, I may end up swapping to instead construct and execute a SqlCommand, and return an ID that ADS can then use to retrieve the result set, as this would remove the need to roll my own .NET -> TSQL datatype conversion code.

@Benjin Benjin marked this pull request as ready for review August 18, 2023 22:01
@Benjin Benjin requested a review from SakshiS-harma August 18, 2023 22:01
@kisantia
Copy link
Contributor

looks like the other tests also need the line ending change made for the ForcedPlanQueries and TrackedQueries tests, now that they're getting past the timezone failure

@Benjin Benjin merged commit 25c18d3 into main Sep 1, 2023
6 checks passed
@Benjin Benjin deleted the benjin/queryStore branch September 1, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants