Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SQL Projects nuget dependency #2253

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Sep 28, 2023

Updating to 0.2.2-preview, and changing references to DSP to use the new enum-based API

@github-actions
Copy link

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@Benjin
Copy link
Contributor Author

Benjin commented Sep 28, 2023

One more change in-flight for SqlProjects that'll let me remove the DSP-SqlPlatforms conversion code from here; gonna hold this for 0.2.2.

Update: 0.2.2's been stuck in the "validating" state for the past few hours. Hopefully the publish completes overnight.

@Benjin Benjin merged commit c7857c2 into main Sep 29, 2023
6 checks passed
@Benjin Benjin deleted the benjin/UpdateProjectsNuget branch September 29, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants