Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sql Nuget version and updated picking v2 perf queries #2301

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Updated sql Nuget version and updated picking v2 perf queries #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<PackageReference Update="Microsoft.Azure.Kusto.Data" Version="9.0.4" />
<PackageReference Update="Microsoft.Azure.Kusto.Language" Version="9.0.4" />
<PackageReference Update="Microsoft.SqlServer.Assessment" Version="[1.1.17]" />
<PackageReference Update="Microsoft.SqlServer.Migration.Assessment" Version="1.0.20230907.105" />
<PackageReference Update="Microsoft.SqlServer.Migration.Assessment" Version="1.0.20231130.1" />
<PackageReference Update="Microsoft.SqlServer.Migration.Logins" Version="1.0.20230407.56" />
<PackageReference Update="Microsoft.SqlServer.Management.QueryStoreModel" Version="163.55.1" />
<PackageReference Update="Microsoft.SqlServer.Management.SqlParser" Version="170.9.0" />
Expand Down
Binary file removed bin/nuget/Microsoft.SqlServer.Migration.Assessment.1.0.20230301.46.nupkg
View file
Open in desktop
Binary file not shown.
Binary file added bin/nuget/Microsoft.SqlServer.Migration.Assessment.1.0.20231130.1.nupkg
View file
Open in desktop
Binary file not shown.
5 changes: 4 additions & 1 deletion src/Microsoft.SqlTools.Migration/SqlDataQueryController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@ public SqlDataQueryController(
this.messages = new List<KeyValuePair<string, DateTime>>();
this.errors = new List<KeyValuePair<string, DateTime>>();
perfDataCache = new SqlPerfDataPointsCache(this.outputFolder, _logger);
dataCollector = new DataPointsCollector(new string[] { connectionString }, _logger);
dataCollector = new DataPointsCollector(
Ramudaykumar marked this conversation as resolved.
Show resolved Hide resolved
new string[] { connectionString },
_logger,
new DataPointsCollectorOptions(true));

// set up timers to run perf/static collection at specified intervals
System.Timers.Timer perfDataCollectionTimer = new System.Timers.Timer();
Expand Down
Loading