Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY]: Package version solving failure with Open-AI library and Semantic Kernel #1223

Closed
lilyydu opened this issue Jan 31, 2024 · 1 comment
Closed
Assignees
Labels
investigating Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label

Comments

@lilyydu
Copy link
Contributor

lilyydu commented Jan 31, 2024

Build has been failing for the embeddings PR due to a version solving issue. The code relies on v1.10.0 for open-ai, but semantic-kernel, which is still being used for Planners and Prompts, uses an older version 0.27.10

This presented 2 options:
(1) Updating our version of semantic-kernel which uses v1.10.0- but this requires updating our code in Planners/Prompts
(2) Removing semantic-kernel from our code completely (original plan but we intended to do this later on initially)

Preferred solution is 2. The scope of changes in #1 seem to be quite extensive, and factoring in the extra time/effort to remove the changes later on seems inefficient (also considering our timeline for GA).

Instead, we can hold off on merging the embeddings code in & implement in the following order:

  • Augmentations
  • Planners
  • Prompts - (already WIP but dependency on 1)
  • Merge embeddings + client code
  • Moderator, models (only AI features dependent on 4)

More details here:
Open-AI Library Package Dependency with Semantic-Kernel.docx

@lilyydu lilyydu self-assigned this Jan 31, 2024
@lilyydu lilyydu added investigating Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label labels Jan 31, 2024
@lilyydu lilyydu mentioned this issue Jan 31, 2024
1 task
@lilyydu
Copy link
Contributor Author

lilyydu commented Feb 7, 2024

Resolved with #1238

@lilyydu lilyydu closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Development

No branches or pull requests

1 participant