Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PY/JS]: Chat Completions Tools - Bug Bash #1955

Closed
16 of 18 tasks
Tracked by #1095
lilyydu opened this issue Aug 27, 2024 · 3 comments
Closed
16 of 18 tasks
Tracked by #1095

[PY/JS]: Chat Completions Tools - Bug Bash #1955

lilyydu opened this issue Aug 27, 2024 · 3 comments
Assignees
@corinagum @BMS-geodev @lilyydu
Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label

Comments

@lilyydu
Copy link
Contributor

lilyydu commented Aug 27, 2024 •
edited by corinagum
Loading

JS samples
Preview Give feedback

PY samples
Preview Give feedback

Directions:

  1. Pull latest changes from this repo and open the sample's folder.
  2. Comment out this code in teamsapp.local.yml:
    image
    This is to make sure you are using the latest code changes, not what is latest published code.
  3. Add AOAI key and endpoint or OAI key to .env, .env.local.user, and update azure.bicep and azure.parameters.json with the key and/or endpoint.

.env.local.user:
image

.env:
image

azure.bicep:
image

  1. Run the sample and if no problems detected, please add a checkmark with your name above. If you do come across any problems, please list details of which sample / what model(s) you used, take screencaps of the chat log, and other error messages or related context, and post them as a comment here. Feel free to put an ❌ with your name in the tasklist above.

Having more than one person per sample per LLM would be much appreciated. Thank you!
@lilyydu lilyydu mentioned this issue Aug 27, 2024
Open
@lilyydu lilyydu changed the title [PY/JS]: Tools Bug Bash [PY/JS]: Chat Completions Tools - Bug Bash Aug 27, 2024
@lilyydu lilyydu added Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label labels Aug 27, 2024
@lilyydu
Copy link
Contributor Author

lilyydu commented Aug 30, 2024 •
edited
Loading

for openai-python, testing with non-specified parallel_tool_calls is throwing 400 because of the AOAI API

#1492

@lilyydu lilyydu mentioned this issue Aug 30, 2024
Merged
1 task
corinagum pushed a commit that referenced this issue Sep 3, 2024
@lilyydu
[PY] chore: update samples to use tools (#1971)
136045a 
## Linked issues

closes: #minor
related: #1955

## Details

Updated ListBot, LightBot, Devops and Langchain to use tools instead of
actions.

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
@BMS-geodev
Copy link
Collaborator

BMS-geodev commented Sep 26, 2024 •
edited
Loading

PY Langchain - AOAI tested with proper creds. Seems fully functional.

@BMS-geodev
Copy link
Collaborator

BMS-geodev commented Oct 3, 2024 •
edited
Loading

PY DevOps bot - AOAI tested and working properly. I've made note of a minor response text formatting issue with the team for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

@BMS-geodev BMS-geodev

@lilyydu lilyydu

Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corinagum @BMS-geodev @lilyydu