Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: Switch to kornia AugmentationSequential #1979

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Apr 3, 2024

Switch to kornia's AugmentationSequential in models submodule

@github-actions github-actions bot added models Models and pretrained weights dependencies Packaging and dependencies labels Apr 3, 2024
@adamjstewart adamjstewart added this to the 0.6.0 milestone Apr 3, 2024
@adamjstewart
Copy link
Collaborator

Can you resolve the merge conflicts?

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are likely many lines in pyproject.toml pytest ignores that could be removed now that we're bumping the min version. Same with all of the resame/align_corners stuff in the data modules. The former we could do now. The latter maybe in a separate PR that updates the data modules?

torchgeo/models/dofa.py Show resolved Hide resolved
torchgeo/models/swin.py Outdated Show resolved Hide resolved
Copy link

@johnnv1 johnnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool patch. What still has the necessity of the augmentation sequential torch geo wrap?

@adamjstewart
Copy link
Collaborator

I think we're just waiting on the next release? #1978

pyproject.toml Show resolved Hide resolved
@adamjstewart adamjstewart merged commit abceea0 into microsoft:main Apr 5, 2024
21 checks passed
@ashnair1 ashnair1 deleted the aug-remove-models branch April 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Packaging and dependencies models Models and pretrained weights
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants