Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms: Switch to kornia AugmentationSequential #2008

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

ashnair1
Copy link
Collaborator

Switch to kornia's AugmentationSequential in transforms submodule

Closes #2002

@github-actions github-actions bot added the testing Continuous integration testing label Apr 17, 2024
@ashnair1
Copy link
Collaborator Author

Will need to push a fix to kornia to allow non-float dtypes.

@adamjstewart
Copy link
Collaborator

Will need to push a fix to kornia to allow non-float dtypes.

Any progress on this?

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Jun 5, 2024

Will need to push a fix to kornia to allow non-float dtypes.

Any progress on this?

kornia/kornia#2882 is nearly complete. Just needs another round of review.

@robmarkcole
Copy link
Contributor

One issue with the switch - the data_key boxes in torchgeo is not an recognised value in kornia implementation, closest is bbox

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Jun 9, 2024

One issue with the switch - the data_key boxes in torchgeo is not an recognised value in kornia implementation, closest is bbox

This is planned to be implemented via #1978.

@johnnv1
Copy link

johnnv1 commented Jun 29, 2024

kornia/kornia#2882 is nearly complete. Just needs another round of review.

@ashnair1 your patch is now available at the latest Kornia release (v0.7.3)

adamjstewart
adamjstewart previously approved these changes Jun 30, 2024
tests/transforms/test_color.py Show resolved Hide resolved
@adamjstewart adamjstewart enabled auto-merge (squash) June 30, 2024 18:19
@adamjstewart adamjstewart merged commit 87a5da2 into microsoft:main Jun 30, 2024
19 checks passed
@ashnair1 ashnair1 deleted the aug-remove-transforms branch July 1, 2024 06:56
@adamjstewart adamjstewart modified the milestone: 0.6.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anomaly with RandomGrayScale tests
4 participants