Port "Avoid resolving source prop type when the target is unknown/any" (#1817)

Author: Andarist

internal/checker/relater.go

@@ -4264,6 +4264,10 @@ func (r *Relater) propertyRelatedTo(source *Type, target *Type, sourceProp *ast.
 func (r *Relater) isPropertySymbolTypeRelated(sourceProp *ast.Symbol, targetProp *ast.Symbol, getTypeOfSourceProperty func(sym *ast.Symbol) *Type, reportErrors bool, intersectionState IntersectionState) Ternary {
 	targetIsOptional := r.c.strictNullChecks && targetProp.CheckFlags&ast.CheckFlagsPartial != 0
 	effectiveTarget := r.c.addOptionalityEx(r.c.getNonMissingTypeOfSymbol(targetProp), false /*isProperty*/, targetIsOptional)
+	// source could resolve to `any` and that's not related to `unknown` target under strict subtype relation
+	if effectiveTarget.flags&core.IfElse(r.relation == r.c.strictSubtypeRelation, TypeFlagsAny, TypeFlagsAnyOrUnknown) != 0 {
+		return TernaryTrue
+	}
 	effectiveSource := getTypeOfSourceProperty(sourceProp)
 	return r.isRelatedToEx(effectiveSource, effectiveTarget, RecursionFlagsBoth, reportErrors, nil /*headMessage*/, intersectionState)
 }

testdata/baselines/reference/submodule/compiler/noCircularitySelfReferentialGetter3.errors.txt

@@ -2,19 +2,19 @@
 
 === noCircularitySelfReferentialGetter3.ts ===
 const a = {
->a : any
->{  prop: 42,  get self() {    return a;  },} satisfies { prop: number; self: any } : { prop: number; readonly self: any; }
->{  prop: 42,  get self() {    return a;  },} : { prop: number; readonly self: any; }
+>a : { prop: number; readonly self: any; }
+>{  prop: 42,  get self() {    return a;  },} satisfies { prop: number; self: any } : { prop: number; readonly self: { prop: number; readonly self: any; }; }
+>{  prop: 42,  get self() {    return a;  },} : { prop: number; readonly self: { prop: number; readonly self: any; }; }
 
   prop: 42,
 >prop : number
 >42 : 42
 
   get self() {
->self : any
+>self : { prop: number; readonly self: any; }
 
     return a;
->a : any
+>a : { prop: number; readonly self: any; }
 
   },
 } satisfies { prop: number; self: any };

testdata/baselines/reference/submodule/compiler/noCircularitySelfReferentialGetter3.errors.txt.diff

@@ -20,5 +20,17 @@ const a = {
 
 const prop = a.self.self.self.self.self.prop;
 >prop : Symbol(prop, Decl(noCircularitySelfReferentialGetter4.ts, 7, 5))
+>a.self.self.self.self.self.prop : Symbol(prop, Decl(noCircularitySelfReferentialGetter4.ts, 0, 11))
+>a.self.self.self.self.self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>a.self.self.self.self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>a.self.self.self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>a.self.self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>a.self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
 >a : Symbol(a, Decl(noCircularitySelfReferentialGetter4.ts, 0, 5))
+>self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>self : Symbol(self, Decl(noCircularitySelfReferentialGetter4.ts, 1, 11))
+>prop : Symbol(prop, Decl(noCircularitySelfReferentialGetter4.ts, 0, 11))
 

testdata/baselines/reference/submodule/compiler/noCircularitySelfReferentialGetter3.types

@@ -2,38 +2,38 @@
 
 === noCircularitySelfReferentialGetter4.ts ===
 const a = {
->a : any
->{  prop: 42,  get self() {    return a;  },} satisfies { prop: number; self: any } : { prop: number; readonly self: any; }
->{  prop: 42,  get self() {    return a;  },} : { prop: number; readonly self: any; }
+>a : { prop: number; readonly self: any; }
+>{  prop: 42,  get self() {    return a;  },} satisfies { prop: number; self: any } : { prop: number; readonly self: { prop: number; readonly self: any; }; }
+>{  prop: 42,  get self() {    return a;  },} : { prop: number; readonly self: { prop: number; readonly self: any; }; }
 
   prop: 42,
 >prop : number
 >42 : 42
 
   get self() {
->self : any
+>self : { prop: number; readonly self: any; }
 
     return a;
->a : any
+>a : { prop: number; readonly self: any; }
 
   },
 } satisfies { prop: number; self: any };
 >prop : number
 >self : any
 
 const prop = a.self.self.self.self.self.prop;
->prop : any
->a.self.self.self.self.self.prop : any
->a.self.self.self.self.self : any
->a.self.self.self.self : any
->a.self.self.self : any
->a.self.self : any
->a.self : any
->a : any
->self : any
->self : any
->self : any
->self : any
->self : any
->prop : any
+>prop : number
+>a.self.self.self.self.self.prop : number
+>a.self.self.self.self.self : { prop: number; readonly self: any; }
+>a.self.self.self.self : { prop: number; readonly self: any; }
+>a.self.self.self : { prop: number; readonly self: any; }
+>a.self.self : { prop: number; readonly self: any; }
+>a.self : { prop: number; readonly self: any; }
+>a : { prop: number; readonly self: any; }
+>self : { prop: number; readonly self: any; }
+>self : { prop: number; readonly self: any; }
+>self : { prop: number; readonly self: any; }
+>self : { prop: number; readonly self: any; }
+>self : { prop: number; readonly self: any; }
+>prop : number