Misc LSP server / fourslash testing improvements #1591
Draft
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
andrewbranch,
Copilot,
gabritto and
sheetalkamat
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the testing infrastructure for the LSP server and fourslash tests by enhancing lifecycle management and logging capabilities. The changes focus on proper context handling, test cleanup, and error reporting.
Key changes:
- Added context-based lifecycle management to the LSP server
- Improved test logging by directing LSP stderr to test output
- Enhanced test cleanup with proper LSP server shutdown and error handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/lsp/server.go | Modified Run method to accept context parameter and removed signal handling |
| internal/fourslash/fourslash.go | Added context management, improved error handling, and redirected LSP stderr to test output |
| cmd/tsgo/main.go | Added signal context creation at main entry point |
| cmd/tsgo/lsp.go | Updated runLSP to accept and pass context to server |
This comment was marked as outdated.
This comment was marked as outdated.
sheetalkamat
approved these changes
Aug 15, 2025
Member
Author
|
No, I just caused a race. Will figure it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the LSP stderr tot.Output(), which means tests will actually get logging.I moved the main context all the way up to
main, since eventually we'll plumb it downward to the other commands. The movement means the LSP tests are not watching signals (which was an oops and caused weirdness).