Merge branch 'main' into mini-website-refresh

Author: mario-guerra

.chronus/changes/deprecate-implicit-multipart-2025-2-14-12-48-39.md

@@ -0,0 +1,20 @@
+---
+changeKind: deprecation
+packages:
+  - "@typespec/http"
+---
+
+Deprecate implicit multipart body
+
+```diff lang=tsp
+op upload(
+  @header contentType: "multipart/form-data",
+  -@body body: {
+  +@multipartBody body: {
+  -  name: string;
+  +  name: HttpPart<string>;
+  -  avatar: bytes;
+  +  avatar: HttpPart<bytes>;
+  }
+): void;
+```

.chronus/changes/deprecate-implicit-multipart-2025-2-14-20-1-30.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: fix
+packages:
+  - "@typespec/http-specs"
+---
+
+Suppress implicit multipart deprecation for this release

.chronus/changes/homepage-link-2025-2-17-9-36-2.md

@@ -0,0 +1,7 @@
+---
+changeKind: internal
+packages:
+  - "@typespec/http-client-js"
+---
+
+Add homepage and readme links

packages/http-client-csharp/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "author": "Microsoft Corporation",
   "description": "The typespec library that can be used to generate C# models from a TypeSpec REST protocol binding",
-  "homepage": "https://github.com/Microsoft/typespec",
+  "homepage": "https://typespec.io",
   "readme": "https://github.com/Microsoft/typespec/blob/main/packages/http-client-csharp/readme.md",
   "license": "MIT",
   "repository": {

packages/http-client-java/package.json

@@ -6,7 +6,7 @@
     "TypeSpec"
   ],
   "author": "Microsoft Corporation",
-  "homepage": "https://github.com/Microsoft/typespec",
+  "homepage": "https://typespec.io",
   "readme": "https://github.com/Microsoft/typespec/blob/main/packages/http-client-java/README.md",
   "repository": {
     "type": "git",

packages/http-client-js/package.json

@@ -2,6 +2,8 @@
   "name": "@typespec/http-client-js",
   "version": "0.1.0",
   "type": "module",
+  "homepage": "https://typespec.io",
+  "readme": "https://github.com/microsoft/typespec/blob/main/packages/http-client-js/README.md",
   "scripts": {
     "build-src": "babel src -d dist/src --extensions .ts,.tsx",
     "build": "tsc -p . && npm run build-src",

packages/http-specs/specs/payload/multipart/main.tsp

@@ -106,6 +106,7 @@ namespace FormData {
   @route("/mixed-parts")
   op basic(
     @header contentType: "multipart/form-data",
+    #suppress "deprecated" "For testing to migrate for 1.0-rc"
     @body body: MultiPartRequest,
   ): NoContentResponse;
 
@@ -166,6 +167,7 @@ namespace FormData {
   @route("/complex-parts")
   op fileArrayAndBasic(
     @header contentType: "multipart/form-data",
+    #suppress "deprecated" "For testing to migrate for 1.0-rc"
     @body body: ComplexPartsRequest,
   ): NoContentResponse;
 
@@ -202,6 +204,7 @@ namespace FormData {
   @route("/json-part")
   op jsonPart(
     @header contentType: "multipart/form-data",
+    #suppress "deprecated" "For testing to migrate for 1.0-rc"
     @body body: JsonPartRequest,
   ): NoContentResponse;
 
@@ -241,6 +244,7 @@ namespace FormData {
   @route("/binary-array-parts")
   op binaryArrayParts(
     @header contentType: "multipart/form-data",
+    #suppress "deprecated" "For testing to migrate for 1.0-rc"
     @body body: BinaryArrayPartsRequest,
   ): NoContentResponse;
 
@@ -275,6 +279,7 @@ namespace FormData {
   @route("/multi-binary-parts")
   op multiBinaryParts(
     @header contentType: "multipart/form-data",
+    #suppress "deprecated" "For testing to migrate for 1.0-rc"
     @body body: MultiBinaryPartsRequest,
   ): NoContentResponse;
 
@@ -304,9 +309,11 @@ namespace FormData {
   @route("/check-filename-and-content-type")
   op checkFileNameAndContentType(
     @header contentType: "multipart/form-data",
+    #suppress "deprecated" "For testing to migrate for 1.0-rc"
     @body body: MultiPartRequest,
   ): NoContentResponse;
 
+  #suppress "deprecated" "For testing to migrate for 1.0-rc"
   @scenario
   @scenarioDoc("""
     Expect request (

packages/http/src/payload.ts

@@ -68,6 +68,14 @@ export function resolveHttpPayload(
   const body = diagnostics.pipe(resolveBody(program, type, metadata, visibility, disposition));
 
   if (body) {
+    if (body.contentTypes.some((x) => x.startsWith("multipart/")) && body.bodyKind === "single") {
+      diagnostics.add({
+        severity: "warning",
+        code: "deprecated",
+        message: `Deprecated: Implicit multipart is deprecated, use @multipartBody instead with HttpPart`,
+        target: body.property ?? type,
+      });
+    }
     if (
       body.contentTypes.includes("multipart/form-data") &&
       body.bodyKind === "single" &&

packages/http/test/parameters.test.ts

@@ -84,6 +84,7 @@ it("emit diagnostic when there are multiple @body param", async () => {
 
 it("emit error if using multipart/form-data contentType parameter with a body not being a model", async () => {
   const [_, diagnostics] = await compileOperations(`
+      #suppress "deprecated" "For testing to migrate for 1.0-rc"
       @get op get(@header contentType: "multipart/form-data", @body body: string | int32): string;
     `);
 

packages/openapi3/test/multipart.test.ts

@@ -73,6 +73,7 @@ worksFor(["3.0.0", "3.1.0"], ({ openApiFor }) => {
       const res = await openApiFor(
         `
       model Form { @header contentType: "multipart/form-data", name: string, profileImage: bytes }
+      #suppress "deprecated" "For testing to migrate for 1.0-rc"
       op upload(...Form): void;
       `,
       );
@@ -88,6 +89,7 @@ worksFor(["3.0.0", "3.1.0"], ({ openApiFor }) => {
       const res = await openApiFor(
         `
       union  MyUnion {string, int32}
+      #suppress "deprecated" "For testing to migrate for 1.0-rc"
       op upload(@header contentType: "multipart/form-data", profileImage: MyUnion): void;
       `,
       );
@@ -108,6 +110,7 @@ worksFor(["3.0.0", "3.1.0"], ({ openApiFor }) => {
     it("part of type `string` produce `type: string`", async () => {
       const res = await openApiFor(
         `
+      #suppress "deprecated" "For testing to migrate for 1.0-rc"
       op upload(@header contentType: "multipart/form-data", name: string): void;
       `,
       );
@@ -128,6 +131,7 @@ worksFor(["3.0.0", "3.1.0"], ({ openApiFor }) => {
     it("part of type `object` produce an object", async () => {
       const res = await openApiFor(
         `
+      #suppress "deprecated" "For testing to migrate for 1.0-rc"
       op upload(@header contentType: "multipart/form-data", address: {city: string, street: string}): void;
       `,
       );
@@ -164,6 +168,7 @@ worksFor(["3.0.0", "3.1.0"], ({ openApiFor }) => {
       
       interface Files {
         @get listFiles(purpose: FilePurpose): string;
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         @post uploadFile(@header contentType: "multipart/form-data", purpose: FilePurpose): string;
       }
       `,
@@ -334,6 +339,7 @@ worksFor(["3.0.0"], ({ openApiFor }) => {
       it("part of type `bytes` produce `type: string, format: binary`", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", profileImage: bytes): void;
         `,
         );
@@ -355,6 +361,7 @@ worksFor(["3.0.0"], ({ openApiFor }) => {
       it("part of type union `bytes | {content: bytes}` produce `type: string, format: binary`", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", profileImage: bytes | {content: bytes}): void;
         `,
         );
@@ -387,6 +394,7 @@ worksFor(["3.0.0"], ({ openApiFor }) => {
       it("part of type `bytes[]` produce `type: array, items: {type: string, format: binary}`", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", profileImage: bytes[]): void;
         `,
         );
@@ -408,6 +416,7 @@ worksFor(["3.0.0"], ({ openApiFor }) => {
       it("bytes inside a json part will be treated as base64 encoded by default(same as for a json body)", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", address: {city: string, icon: bytes}): void;
         `,
         );
@@ -585,6 +594,7 @@ worksFor(["3.1.0"], ({ openApiFor }) => {
       it("part of type `bytes` produce `{}`", async () => {
         const res = await openApiFor(
           `
+      #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", profileImage: bytes): void;
         `,
         );
@@ -603,6 +613,7 @@ worksFor(["3.1.0"], ({ openApiFor }) => {
       it("part of type union `bytes | {content: bytes}` produce `{} | { content: {type: string, contentEncoding: 'base64' }`", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", profileImage: bytes | {content: bytes}): void;
         `,
         );
@@ -632,6 +643,7 @@ worksFor(["3.1.0"], ({ openApiFor }) => {
       it("part of type `bytes[]` produce `type: array, items: {}`", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", profileImage: bytes[]): void;
         `,
         );
@@ -653,6 +665,7 @@ worksFor(["3.1.0"], ({ openApiFor }) => {
       it("bytes inside a json part will be treated as base64 encoded by default(same as for a json body)", async () => {
         const res = await openApiFor(
           `
+        #suppress "deprecated" "For testing to migrate for 1.0-rc"
         op upload(@header contentType: "multipart/form-data", address: {city: string, icon: bytes}): void;
         `,
         );