Skip to content

Commit

Permalink
fixing warning identification in outputs when building through tasks (#…
Browse files Browse the repository at this point in the history
…3142)

* changed tasks warning check from checking 'warning' to checking ': warning'

* updated changelog
  • Loading branch information
snehara99 authored Apr 27, 2023
1 parent 9fc54a9 commit 17d743e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
Bug Fixes:
- When `cmake.buildTasks` is `true`, CMake tasks in `tasks.json` that do not specify `targets` will no longer cause the build to fail. [#3123](https://github.com/microsoft/vscode-cmake-tools/issues/3123)
- Paths containing `mingw` are no longer removed from the `PATH` environment variable when configuring a project without specifying a kit. [#3136](https://github.com/microsoft/vscode-cmake-tools/issues/3136)
- Warning messages are no longer triggered by targets containing "warning" in the file path when running `Tasks: Run Build Task`. [#3118](https://github.com/microsoft/vscode-cmake-tools/issues/3118)
- Unable to resolve `cmake-tools-schema:/schemas/CMakePresets*.json`. [#2587](https://github.com/microsoft/vscode-cmake-tools/issues/2587) [#3108](https://github.com/microsoft/vscode-cmake-tools/issues/3108)

## 1.14.30
Expand Down
2 changes: 1 addition & 1 deletion src/cmakeTaskProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ export class CustomBuildTaskTerminal implements vscode.Pseudoterminal, proc.Outp
this._process = undefined;
if (result.retc) {
this.writeEmitter.fire(localize("build.finished.with.error", "{0} finished with error(s).", taskName) + endOfLine);
} else if (result.stderr || (result.stdout && result.stdout.includes("warning"))) {
} else if (result.stderr || (result.stdout && result.stdout.includes(": warning"))) {
this.writeEmitter.fire(localize("build.finished.with.warnings", "{0} finished with warning(s).", taskName) + endOfLine);
} else {
this.writeEmitter.fire(localize("build.finished.successfully", "{0} finished successfully.", taskName) + endOfLine);
Expand Down

0 comments on commit 17d743e

Please sign in to comment.