From 3305ff22fc000533f67b66bb107f53401e42bb3c Mon Sep 17 00:00:00 2001
From: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com>
Date: Fri, 20 Sep 2024 13:01:34 -0400
Subject: [PATCH] Ensure signing/packaging works as expected (#4088)

* test out signing js and packaging it without messing up sign

* yarn compile-production

* temp image override

* confirmed, this fixes signing
---
 jobs/release/prerelease.yml | 3 ---
 jobs/release/release.yml    | 3 ---
 jobs/shared/build.yml       | 2 +-
 package.json                | 1 -
 4 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/jobs/release/prerelease.yml b/jobs/release/prerelease.yml
index e9f662558..1ce92eead 100644
--- a/jobs/release/prerelease.yml
+++ b/jobs/release/prerelease.yml
@@ -29,9 +29,6 @@ extends:
         templateContext:
           type: releaseJob
           isProduction: true
-          sdl:
-            codeSignValidation:
-              additionalTargetsGlobPattern: -|**\*.js
           inputs:
           - input: pipelineArtifact
             pipeline: BuildPrereleasePipeline
diff --git a/jobs/release/release.yml b/jobs/release/release.yml
index 1d104060d..5da98c783 100644
--- a/jobs/release/release.yml
+++ b/jobs/release/release.yml
@@ -61,9 +61,6 @@ extends:
         templateContext:
           type: releaseJob
           isProduction: true
-          sdl:
-            codeSignValidation:
-              additionalTargetsGlobPattern: -|**\*.js
           inputs:
           - input: pipelineArtifact
             pipeline: BuildReleasePipeline
diff --git a/jobs/shared/build.yml b/jobs/shared/build.yml
index a7bf476b7..7244f4e4f 100644
--- a/jobs/shared/build.yml
+++ b/jobs/shared/build.yml
@@ -58,7 +58,7 @@ steps:
   displayName: Build files
   inputs:
     script: |
-      npm run vscode:prepublish
+      yarn compile-production
 - task: MSBuild@1
   displayName: Sign files
   inputs:
diff --git a/package.json b/package.json
index 49256daf9..6a5e41880 100644
--- a/package.json
+++ b/package.json
@@ -3677,7 +3677,6 @@
     "@test": "out/test/"
   },
   "scripts": {
-    "vscode:prepublish": "yarn run compile-production",
     "compile": "yarn install && webpack --mode development",
     "compile-watch": "yarn install && webpack --mode development --watch --progress",
     "compile-production": "yarn install && yarn run translations-generate && webpack --env BUILD_VSCODE_NLS=true --mode production",