diff --git a/CHANGELOG.md b/CHANGELOG.md index e36ee52b9..389742ad5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ Improvements: - Fix "Unable to resolve configuration with compilerPath" issue for Swift. [#4097](https://github.com/microsoft/vscode-cmake-tools/issues/4097) - Ensure that any uses of `proc.spawn` work, especially for .bat and .cmd files, due to VS Code updating to Node 20. [#4037](https://github.com/microsoft/vscode-cmake-tools/issues/4037) - Ensure that stopping tests actually forces the tests to stop running. [#2095](https://github.com/microsoft/vscode-cmake-tools/issues/2095) +- Retire the Show Options Moved Notification [#4039](https://github.com/microsoft/vscode-cmake-tools/issues/4039) Bug Fixes: diff --git a/package.json b/package.json index f279ccbea..b10395ddf 100644 --- a/package.json +++ b/package.json @@ -2747,12 +2747,6 @@ } } }, - "cmake.showOptionsMovedNotification": { - "type": "boolean", - "default": true, - "description": "%cmake-tools.configuration.cmake.showOptionsMovedNotification%", - "scope": "application" - }, "cmake.showConfigureWithDebuggerNotification": { "type": "boolean", "default": true, diff --git a/package.nls.json b/package.nls.json index c78efd003..38bb7c7d7 100644 --- a/package.nls.json +++ b/package.nls.json @@ -188,7 +188,6 @@ "cmake-tools.configuration.cmake.touchbar.visibility.description": "Configures how the extension displays the buttons on a MacBook Touch Bar.", "cmake-tools.configuration.cmake.touchbar.visibility.default.description": "Show Touch Bar buttons on supported systems.", "cmake-tools.configuration.cmake.touchbar.visibility.hidden.description": "Do not show Touch Bar buttons.", - "cmake-tools.configuration.cmake.showOptionsMovedNotification": "Enables the notification regarding the status bar options moving to the Project Status View to show when the extension starts.", "cmake-tools.configuration.cmake.showConfigureWithDebuggerNotification": "Enables the pop-up that asks the user if, upon a failed configure, they want to configure with the CMake Debugger.", "cmake-tools.configuration.cmake.showNotAllDocumentsSavedQuestion": "Enables the pop-up that asks the user if they want to continue the build despite some files possibly not being saved. If not enabled, the build will be continued.", "cmake-tools.configuration.cmake.options.advanced.statusBarVisibility.visible.description": "Show the status bar option at full size.", diff --git a/src/config.ts b/src/config.ts index 6c2345361..b65b19ae7 100644 --- a/src/config.ts +++ b/src/config.ts @@ -207,7 +207,6 @@ export interface ExtensionConfigurationSettings { loggingLevel: LogLevelKey; additionalKits: string[]; touchbar: TouchBarConfig; - showOptionsMovedNotification: boolean; options: OptionConfig; useCMakePresets: UseCMakePresets; useVsDeveloperEnvironment: UseVsDeveloperEnvironment; @@ -621,7 +620,6 @@ export class ConfigurationReader implements vscode.Disposable { loggingLevel: new vscode.EventEmitter(), additionalKits: new vscode.EventEmitter(), touchbar: new vscode.EventEmitter(), - showOptionsMovedNotification: new vscode.EventEmitter(), options: new vscode.EventEmitter(), useCMakePresets: new vscode.EventEmitter(), useVsDeveloperEnvironment: new vscode.EventEmitter(), diff --git a/src/extension.ts b/src/extension.ts index 1e52bcd49..b22908de8 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -2357,22 +2357,6 @@ export async function activate(context: vscode.ExtensionContext): Promise { - if (selection !== undefined) { - if (selection === localize('options.moved.notification.configure.cmake.options', 'Configure CMake Options Visibility')) { - await vscode.commands.executeCommand('workbench.action.openSettings', 'cmake.options'); - } else if (selection === localize('options.moved.notification.do.not.show', "Do Not Show Again")) { - await vscode.workspace.getConfiguration('cmake').update('showOptionsMovedNotification', false, vscode.ConfigurationTarget.Global); - } - } - }); - } - // Start with a partial feature set view. The first valid CMake project will cause a switch to full feature set. await enableFullFeatureSet(false); diff --git a/test/unit-tests/config.test.ts b/test/unit-tests/config.test.ts index 2dec3e5c5..a2d04c04a 100644 --- a/test/unit-tests/config.test.ts +++ b/test/unit-tests/config.test.ts @@ -65,7 +65,6 @@ function createConfig(conf: Partial): Configurat touchbar: { visibility: "default" }, - showOptionsMovedNotification: true, options: { advanced: {}, statusBarVisibility: "visible"