Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loc]Strings "Debug Tests" in Testing panel is not localized #4236

Open
Yingzi1234 opened this issue Jan 14, 2025 · 8 comments · Fixed by #4240
Open

[loc]Strings "Debug Tests" in Testing panel is not localized #4236

Yingzi1234 opened this issue Jan 14, 2025 · 8 comments · Fixed by #4240
Assignees
Labels
bug a bug in the product world ready World Readiness - ensuring we are globally ready with our localized content
Milestone

Comments

@Yingzi1234
Copy link
Collaborator

Yingzi1234 commented Jan 14, 2025

Brief Issue Summary

More info:

  1. Repro Language: All loc languages
  2. Repro platform: Windows, Linux, Mac

Repro steps:

  1. Open VS Code and change the display language to ITA
  2. Download and unzip CMakeProject1.zip
  3. Open the project with VS Code
  4. Click Testing in left navigation bar
  5. Click the down arrow next to the debug test

Actual result:
Strings "Debug Tests" in Testing panel is not localized
Image

Expected result:
Strings "Debug Tests" in Testing panel is localized

@github-project-automation github-project-automation bot moved this to Blocked in CMake Tools Jan 14, 2025
@Yingzi1234 Yingzi1234 added bug a bug in the product and removed triage labels Jan 14, 2025
@gcampbell-msft
Copy link
Collaborator

gcampbell-msft commented Jan 14, 2025

This is because we don't have these localized, we need to fix. See ctest.ts where we create run profiles, I'll add this to 1.20 and get to it soon.

@gcampbell-msft gcampbell-msft added this to the 1.20 milestone Jan 14, 2025
@gcampbell-msft gcampbell-msft moved this from Blocked to Ready to be Assigned in CMake Tools Jan 14, 2025
@gcampbell-msft gcampbell-msft added the world ready World Readiness - ensuring we are globally ready with our localized content label Jan 14, 2025
@gcampbell-msft gcampbell-msft self-assigned this Jan 14, 2025
@gcampbell-msft gcampbell-msft moved this from Ready to be Assigned to In Progress in CMake Tools Jan 14, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Completed in CMake Tools Jan 17, 2025
@Yingzi1234
Copy link
Collaborator Author

Verified on CMake Tools v1.20.39(pre-release), this bug is still reproducing, so reopen it.

@Yingzi1234 Yingzi1234 reopened this Jan 21, 2025
@Yingzi1234 Yingzi1234 removed the triage label Jan 22, 2025
@gcampbell-msft gcampbell-msft closed this as completed by moving to Completed in CMake Tools Jan 30, 2025
@Yingzi1234
Copy link
Collaborator Author

Yingzi1234 commented Feb 11, 2025

@gcampbell-msft We verified this issue on latest version 1.20.47(pre-release), you can get the details below. And we will re-open this issue, thank you!
Image

@gcampbell-msft
Copy link
Collaborator

I just tested and found that it's fixed.

Image

@Yingzi1234
Copy link
Collaborator Author

Yingzi1234 commented Feb 12, 2025

@gcampbell-msft The untranslated position is on the tooltip after expanding the button, rather than hovering directly over the button. But we noticed that in the latest version v1.20.49(pre-release) there is no more expand button, is this a feature change?

1.20.47(pre-release) With Expand Button
Image

1.20.49(pre-release) Without Expand Button
Image

@gcampbell-msft
Copy link
Collaborator

What is it that is in the parenthesis ?

@gcampbell-msft
Copy link
Collaborator

Update, I've figured it out, this is not coming from our extension, if you have the Test Explorer UI extension installed, it also installs the Test Adapter Converter, and this is where this is coming from.

If you uninstall those, you'll see that you only see our extensions entry point.

@Yingzi1234
Copy link
Collaborator Author

@gcampbell-msft The extension case still doesn't exist without these two plugins installed. You can get the details below.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the product world ready World Readiness - ensuring we are globally ready with our localized content
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants