Fix for 1842: don't ignore empty string cache variables #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcampbell-msft
previously approved these changes
Jul 28, 2023
andreeis
commented
Jul 31, 2023
snehara99
approved these changes
Jul 31, 2023
andreeis
deleted the
dev/andris/cmake_tools_fix1842_empty_string_cacheVar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for request #1842: don't ignore empty string cache variables when configuring from presets.
I checked and when using settings and kits, such empty cache variables are already seen and passed to the cmake configure command, no extra fix was needed.