-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl3137 - SidePanel: Add buttons for project #3354
Conversation
…ode-cmake-tools into Local/ProjectButtons
@vlavati Where did you grab the icons that you are adding to the code from? We need to ensure we know where they came from and ensure that we have legal rights to use those in the product. |
@vlavati Additionally, please make sure to make a CHANGELOG change to mark the change there and give yourself credit. Please follow the pattern of the changelog entries already present. |
Hi, @gcampbell-msft ! The added icons are drawn by me. So I hope they are under the same license agreement like the code. I tried to use the same colors as other icons have. |
Perfect! This should be safe. I've approved the code. I will do a couple more tests to make sure everything works and the icons look good in all themes. Pending no issues, we'll take this change! |
@snehara99 Requesting your review before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine for me :)
Windows tests are currently known to fail, merging. |
This change addresses item #3137
This changes visible behavior
The following changes are proposed: