Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl3137 - SidePanel: Add buttons for project #3354

Merged
merged 10 commits into from
Oct 2, 2023

Conversation

vlavati
Copy link
Contributor

@vlavati vlavati commented Sep 24, 2023

This change addresses item #3137

This changes visible behavior

The following changes are proposed:

  • add configure,build,clean buttons on SidePanel for Project item
  • add clean icons

@gcampbell-msft gcampbell-msft added this to the 1.16 milestone Sep 27, 2023
@gcampbell-msft
Copy link
Collaborator

@vlavati Where did you grab the icons that you are adding to the code from? We need to ensure we know where they came from and ensure that we have legal rights to use those in the product.

@gcampbell-msft
Copy link
Collaborator

@vlavati Additionally, please make sure to make a CHANGELOG change to mark the change there and give yourself credit. Please follow the pattern of the changelog entries already present.

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@vlavati
Copy link
Contributor Author

vlavati commented Sep 28, 2023

@vlavati Where did you grab the icons that you are adding to the code from? We need to ensure we know where they came from and ensure that we have legal rights to use those in the product.

Hi, @gcampbell-msft ! The added icons are drawn by me. So I hope they are under the same license agreement like the code. I tried to use the same colors as other icons have.

@gcampbell-msft
Copy link
Collaborator

@vlavati Where did you grab the icons that you are adding to the code from? We need to ensure we know where they came from and ensure that we have legal rights to use those in the product.

Hi, @gcampbell-msft ! The added icons are drawn by me. So I hope they are under the same license agreement like the code. I tried to use the same colors as other icons have.

Perfect! This should be safe. I've approved the code. I will do a couple more tests to make sure everything works and the icons look good in all themes. Pending no issues, we'll take this change!

@gcampbell-msft
Copy link
Collaborator

@snehara99 Requesting your review before merging.

Copy link
Contributor

@snehara99 snehara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine for me :)

@gcampbell-msft
Copy link
Collaborator

Windows tests are currently known to fail, merging.

@gcampbell-msft gcampbell-msft merged commit c146ec4 into microsoft:main Oct 2, 2023
3 of 4 checks passed
@vlavati vlavati deleted the Local/ProjectButtons branch October 2, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants