Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mementos for state management for pinned commands #4175

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

gcampbell-msft
Copy link
Collaborator

Fixes #3977

This changes how our pinned commands view interacts with user settings

The following changes are proposed:

  • Rather than updating user settings when commands are pinned/unpinned, we update a memento that tracks session to session state.
  • Add default settings for the cmake.pinnedCommands setting for the task runners.
  • Modify the behavior of the cmake.pinnedCommands setting. It no longer is a place that we store everything that is currently pinned. It only stores things that the user always wants to pin by default, regardless of whether they've unpinned it in the past.

Video

PinnedCommands.mp4

@gcampbell-msft
Copy link
Collaborator Author

@paulmaybee Ping for review.

@gcampbell-msft gcampbell-msft enabled auto-merge (squash) November 20, 2024 14:51
@gcampbell-msft gcampbell-msft merged commit bc0f5ec into main Nov 20, 2024
4 checks passed
@gcampbell-msft gcampbell-msft deleted the dev/gcampbell/PinnedCommands branch November 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake.pinnedCommands added automatically to settings
2 participants