Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger an IntelliSense update on fileChanged/Created/Deleted if it's not a C/C++ file #11744

Open
sean-mcmanus opened this issue Nov 30, 2023 · 1 comment
Labels
enhancement Improvement to an existing feature Language Service performance
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

          > @bobbrow fileChanged/Created/Deleted triggers an IntelliSense update unless the file or the file's folder is filtered from a files.exclude setting. So sure you can put the cmake build folder in your workspace folder, but you should also add it to the C_Cpp.files.exclude to avoid unnecessary IntelliSense updating.

Can we change that behavior? If it's obviously not a C or C++ file, I don't see why we would want to trigger an IntelliSense update. We have filters for non-C/C++ files (based on file extension) in the TypeScript code so it doesn't seem wrong to do the same thing in the language server.

Originally posted by @bobbrow in #10651 (comment)

@sean-mcmanus sean-mcmanus added Language Service enhancement Improvement to an existing feature performance labels Nov 30, 2023
Copy link

This feature request is being closed due to insufficient upvotes. Please leave a 👍-upvote or 👎-downvote reaction on the issue to help us prioritize it. When enough upvotes are received, this issue will be eligible for our backlog.

@github-actions github-actions bot added the more votes needed Issues that have been postponed until more community members upvote it label Jan 29, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
@github-actions github-actions bot added this to the Triage milestone Jan 29, 2024
@Colengms Colengms removed the more votes needed Issues that have been postponed until more community members upvote it label Jan 29, 2024
@Colengms Colengms modified the milestones: Triage, Backlog Jan 29, 2024
@Colengms Colengms reopened this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature Language Service performance
Projects
None yet
Development

No branches or pull requests

2 participants